diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2020-09-24 17:44:23 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2020-09-24 20:37:56 +0200 |
commit | 5d67dcc922f831d91424cae8d8758f067a6781b0 (patch) | |
tree | 4bc5748974dc2f9a95b82b0941e4212a9d47b4a3 /sax/Makefile | |
parent | cc2060fb21d48d775e5a85b9080c10589ab7287e (diff) |
PythonTest CPPUNITTRACE='gdb --args' needs to tunnel setting LD_LIBRARY_PATH
...so that it doesn't affect gdb itself, just like CppunitTest already did.
Otherwise, e.g.
make PythonTest_sc_python CPPUNITTRACE='gdb --args'
in a Linux ASan and --enable-python=fully-internal build on Fedora 32 would fail
with
> gdb: symbol lookup error: instdir/program/libpython3.8.so.1.0: undefined symbol: __asan_option_detect_stack_use_after_return
as /usr/bin/gdb would try to use LO's instdir/program/libpython3.8.so.1.0
instead of /usr/lib64/libpython3.8.so.1.0.
So, at least on Linux, the gb_PythonTest_PRECOMMAND settings are now passed into
the test process either directly upfront (if gb_PythonTest_GDBTRACE is not set)
or tunneled past gdb via gb_PythonTest_GDBTRACE (if it is set). At least on
some platforms, gb_PythonTest_PRECOMMAND has a different value than
gb_CppunitTest_CPPTESTPRECOMMAND, so gb_CppunitTest_GDBTRACE would reflect the
settings from gb_CppunitTest_CPPTESTPRECOMMAND but not from
gb_PythonTest_PRECOMMAND, so introduce a new gb_PythonTest_GDBTRACE (which is to
gb_PythonTest_PRECOMMAND what gb_CppunitTest_GDBTRACE is to
gb_CppunitTest_CPPTESTPRECOMMAND).
macOS with its split gb_CppunitTest_{,PRE,POST}GDBTRACE variables will likely
need some work to adopt that to PythonTest, but which is rather orthogonal to
this change, so just note that as a TODO for now.
Change-Id: I7e6681de638095cb58b44de381248ae7326ce412
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103345
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'sax/Makefile')
0 files changed, 0 insertions, 0 deletions