diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-06 20:01:50 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-11 11:58:37 +0100 |
| commit | 93c64a61f2c84e684050294a1391cd32425b7837 (patch) | |
| tree | 00aad2cb8f3ee29ba4ac99e159e26fb8d71d2f33 /sax | |
| parent | 1fde62018c8d3344a3408c7b6317120aefc778fb (diff) | |
loplugin:stringview
Add new methods "subView" to O(U)String to return substring views
of the underlying data.
Add a clang plugin to warn when replacing existing calls to copy()
would be better to use subView().
Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sax')
| -rw-r--r-- | sax/qa/cppunit/xmlimport.cxx | 4 | ||||
| -rw-r--r-- | sax/source/fastparser/fastparser.cxx | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/sax/qa/cppunit/xmlimport.cxx b/sax/qa/cppunit/xmlimport.cxx index a70627e7a798..1ae4a0320a47 100644 --- a/sax/qa/cppunit/xmlimport.cxx +++ b/sax/qa/cppunit/xmlimport.cxx @@ -108,7 +108,7 @@ OUString TestDocumentHandler::canonicalform(const OUString &sName, const OUStrin if ( nIndex >= 0 ) { OUString sNamespace = getNamespace( sName.copy( 0, nIndex ) ); - return sNamespace + sName.copy(nIndex); + return sNamespace + sName.subView(nIndex); } else { @@ -231,7 +231,7 @@ OUString resolveNamespace( const OUString& aName ) if ( aName.getLength() > index + 1 ) { OUString aAttributeName = getNamespaceValue( aName.copy( 0, index ) ) + - ":" + aName.copy( index + 1 ); + ":" + aName.subView( index + 1 ); return aAttributeName; } } diff --git a/sax/source/fastparser/fastparser.cxx b/sax/source/fastparser/fastparser.cxx index d51f471b43a1..e7f21da8e658 100644 --- a/sax/source/fastparser/fastparser.cxx +++ b/sax/source/fastparser/fastparser.cxx @@ -1485,7 +1485,7 @@ static bool NormalizeW3URI( OUString& rName ) { const OUString& sURISuffix = XML_URI_XFORMS_SUFFIX ; sal_Int32 nCompareFrom = rName.getLength() - sURISuffix.getLength(); - if( rName.copy( nCompareFrom ) == sURISuffix ) + if( rName.subView( nCompareFrom ) == sURISuffix ) { // found W3 prefix, and xforms suffix rName = XML_N_XFORMS_1_0; @@ -1568,9 +1568,9 @@ static bool NormalizeOasisURN( OUString& rName ) // replace [tcid] with current TCID and version with current version. - rName = rName.copy( 0, nTCIdStart ) + + rName = rName.subView( 0, nTCIdStart ) + XML_OPENDOCUMENT + - rName.copy( nTCIdEnd, nVersionStart-nTCIdEnd ) + + rName.subView( nTCIdEnd, nVersionStart-nTCIdEnd ) + XML_1_0; return true; |