diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-03-12 08:55:15 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-03-12 09:22:20 +0100 |
| commit | b480819dc4133f587eb960143128a7d85a44da9a (patch) | |
| tree | b7677157cbae13afc4c87e4621545bffbc61c726 /sax | |
| parent | b271cc46851c61ddef20dc869bf339c857f76b18 (diff) | |
Revert "loplugin:constfields in reportdesign,sal,sax"
This reverts commit d4d37662b090cb237585156a47cd8e1f1cbe2656.
Now that we know that making fields has negative side effects
like disabling assignment operator generation.
Change-Id: Idef4937b89a83d2efbfaf0ab87d059a0143c0164
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90364
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sax')
| -rw-r--r-- | sax/source/expatwrap/sax_expat.cxx | 2 | ||||
| -rw-r--r-- | sax/source/fastparser/fastparser.cxx | 6 | ||||
| -rw-r--r-- | sax/source/tools/fastserializer.hxx | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/sax/source/expatwrap/sax_expat.cxx b/sax/source/expatwrap/sax_expat.cxx index 8218436b4569..3172fbe89503 100644 --- a/sax/source/expatwrap/sax_expat.cxx +++ b/sax/source/expatwrap/sax_expat.cxx @@ -387,7 +387,7 @@ class ParserCleanup { private: SaxExpatParser_Impl& m_rParser; - XML_Parser const m_xmlParser; + XML_Parser m_xmlParser; public: ParserCleanup(SaxExpatParser_Impl& rParser, XML_Parser xmlParser) : m_rParser(rParser) diff --git a/sax/source/fastparser/fastparser.cxx b/sax/source/fastparser/fastparser.cxx index f70995763c4c..81591e4a3649 100644 --- a/sax/source/fastparser/fastparser.cxx +++ b/sax/source/fastparser/fastparser.cxx @@ -92,8 +92,8 @@ struct Event struct NameWithToken { - OUString const msName; - sal_Int32 const mnToken; + OUString msName; + sal_Int32 mnToken; NameWithToken(const OUString& sName, sal_Int32 nToken) : msName(sName), mnToken(nToken) {} @@ -102,7 +102,7 @@ struct NameWithToken struct SaxContext { Reference< XFastContextHandler > mxContext; - sal_Int32 const mnElementToken; + sal_Int32 mnElementToken; OUString maNamespace; OUString maElementName; diff --git a/sax/source/tools/fastserializer.hxx b/sax/source/tools/fastserializer.hxx index ba956610f533..0b7ad72d8c0c 100644 --- a/sax/source/tools/fastserializer.hxx +++ b/sax/source/tools/fastserializer.hxx @@ -35,7 +35,7 @@ namespace sax_fastparser { struct TokenValue { - sal_Int32 const nToken; + sal_Int32 nToken; const char *pValue; TokenValue(sal_Int32 _nToken, const char *_pValue) : nToken(_nToken), pValue(_pValue) {} }; |