Go through all ScEditCell instantiations and fix memory leaks.

Changed the signature of the constructor (one that clones the text object)
to take a reference instead of a pointer, to smoke out the callers that
use this constructor.  Went through all its callers and made changes to
either 1) pass ownership to the cell instance (if the text object uses
the SfxItemPool instance returned from ScDocument::GetEditPool()), or 2)
pass as const reference to make it clear that the instance will get cloned.

Change-Id: I669e066d4739536bf8d3b356186503dcdfa303b0

1 files changed, 14 insertions, 2 deletions

diff --git a/sc/inc/cell.hxx b/sc/inc/cell.hxx
index a66d7795fd0d..a6d1480923e2 100644
--- a/sc/inc/cell.hxx
+++ b/sc/inc/cell.hxx
@@ -244,8 +244,20 @@ public:
      */
     ScEditCell(EditTextObject* pObject, ScDocument* pDocP);
 
-                    ScEditCell( const EditTextObject* pObject, ScDocument*,
-                                const SfxItemPool* pFromPool /* = NULL */ );
+    /**
+     * Constructor.  The caller is responsible for deleting the text object
+     * instance passed on to this constructor, since it creates a clone and
+     * stores it instead of the original.
+     *
+     * @param rObject text object to clone from.
+     * @param pDocP pointer to the document instance.
+     * @param pFromPool pointer to SfxItemPool instance that the new text
+     *                  object that is to be stored in the cell instance
+     *                  should use.  If it's NULL, it uses the default pool
+     *                  for edit cells from the document instance (one
+     *                  returned from GetEditPool()).
+     */
+    ScEditCell(const EditTextObject& rObject, ScDocument* pDocP, const SfxItemPool* pFromPool);
     ScEditCell(const ScEditCell& rCell, ScDocument& rDoc, const ScAddress& rDestPos);
                     // for line breaks
                     ScEditCell( const rtl::OUString& rString, ScDocument* );