diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2020-09-15 14:21:37 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2020-09-16 22:27:54 +0200 |
| commit | d9ee08d6fdc23cafa606bbbebd0b64a559fcf24c (patch) | |
| tree | d1f4e3038f5f6fcf2bf69452e426f97c4706d84f /sc/inc/chgtrack.hxx | |
| parent | c3634ad65b459036f47ab2ba37c377e5a5e99d52 (diff) | |
ScFormulaCell ctor variant never called with null ScDocument*
can be shown by readjusting ScXMLChangeTrackingImportHelper
members to explicitly pass the target ScDocument around and
identify there is no null case path possible
Change-Id: I15a4eadfe4bfadf97365f9a15c6ec5572d77d578
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102869
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sc/inc/chgtrack.hxx')
| -rw-r--r-- | sc/inc/chgtrack.hxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sc/inc/chgtrack.hxx b/sc/inc/chgtrack.hxx index 94062c846836..c5af0df88064 100644 --- a/sc/inc/chgtrack.hxx +++ b/sc/inc/chgtrack.hxx @@ -851,7 +851,7 @@ class SAL_DLLPUBLIC_RTTI ScChangeTrack : public utl::ConfigurationListener ScChangeActionLinkEntry* pLinkInsertTab; ScChangeActionLinkEntry* pLinkMove; std::optional<ScChangeTrackMsgInfo> xBlockModifyMsg; - ScDocument* pDoc; + ScDocument& rDoc; sal_uLong nActionMax; sal_uLong nGeneratedMin; sal_uLong nMarkLastSaved; @@ -950,8 +950,8 @@ public: SCSIZE ComputeContentSlot( sal_Int32 nRow ) const; - SC_DLLPUBLIC ScChangeTrack( ScDocument* ); - ScChangeTrack(ScDocument* pDocP, const std::set<OUString>& aTempUserCollection); // only to use in the XML import + SC_DLLPUBLIC ScChangeTrack( ScDocument& ); + ScChangeTrack(ScDocument& rDocP, const std::set<OUString>& aTempUserCollection); // only to use in the XML import SC_DLLPUBLIC virtual ~ScChangeTrack() override; void Clear(); @@ -977,7 +977,7 @@ public: SC_DLLPUBLIC void SetUser( const OUString& rUser ); const OUString& GetUser() const { return maUser;} const std::set<OUString>& GetUserCollection() const { return maUserCollection;} - ScDocument* GetDocument() const { return pDoc; } + ScDocument& GetDocument() const { return rDoc; } // for import filter const DateTime& GetFixDateTime() const { return aFixDateTime; } |