diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2022-04-12 14:58:33 +0200 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2022-04-12 23:10:16 +0200 |
| commit | 4d45d9886fa5830f4c8c92268ffca4297650ed70 (patch) | |
| tree | a16950f628972a6d4d2e1b328b046bcdb7deddc6 /sc/inc/column.hxx | |
| parent | e3830b06a9886620ed432a011d2de2abbb7a3a12 (diff) | |
don't artificially clamp attribute iterators range
Even ScDocument::GetDefPattern() can be modified by the user (it's
the default style that can be edited), so it's conceptually
incorrect to ignore it while iterating, and clamping to allocated
columns is also no longer needed. If this makes some code slow,
then that needs explicit handling in that code or some other
way of speeding things up.
Change-Id: I4a7c7fef0a8625b559bbce4580df19a5e9ed92a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132911
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'sc/inc/column.hxx')
| -rw-r--r-- | sc/inc/column.hxx | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx index 0a2b16c809d9..676e3fc0e634 100644 --- a/sc/inc/column.hxx +++ b/sc/inc/column.hxx @@ -166,7 +166,6 @@ public: std::unique_ptr<ScAttrIterator> CreateAttrIterator( SCROW nStartRow, SCROW nEndRow ) const; bool IsAllAttrEqual( const ScColumnData& rCol, SCROW nStartRow, SCROW nEndRow ) const; - bool HasNonDefPattern( SCROW nStartRow, SCROW nEndRow ) const; void ClearSelectionItems( const sal_uInt16* pWhich, const ScMarkData& rMark, SCCOL nCol ); void ChangeSelectionIndent( bool bIncrement, const ScMarkData& rMark, SCCOL nCol ); @@ -864,11 +863,6 @@ inline bool ScColumnData::IsAllAttrEqual( const ScColumnData& rCol, SCROW nStart return pAttrArray->IsAllEqual( *rCol.pAttrArray, nStartRow, nEndRow ); } -inline bool ScColumnData::HasNonDefPattern( SCROW nStartRow, SCROW nEndRow ) const -{ - return pAttrArray->HasNonDefPattern( nStartRow, nEndRow ); -} - inline bool ScColumn::IsVisibleAttrEqual( const ScColumn& rCol, SCROW nStartRow, SCROW nEndRow ) const { return pAttrArray->IsVisibleEqual( *rCol.pAttrArray, nStartRow, nEndRow ); |