diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-03-27 10:11:51 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2018-03-27 13:30:40 +0200 |
| commit | edfa0562617c1330cc00923a5cf6e5916bacfed0 (patch) | |
| tree | f397da4f7dbf2e137a73e7df931348867339c104 /sc/inc/dbdata.hxx | |
| parent | 3acc5a2383f5b0458e3caf1505fe6b8ad7dc3fb0 (diff) | |
ofz#7121 NamedDBs::insert takes ownership of its argument
at one point this was based on std::auto_ptr and didn't
free its arg on failure
Change-Id: I8aeed6876d80b7ebe4ebb5e2cfd12e00420bd207
Reviewed-on: https://gerrit.libreoffice.org/51932
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sc/inc/dbdata.hxx')
| -rw-r--r-- | sc/inc/dbdata.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/inc/dbdata.hxx b/sc/inc/dbdata.hxx index 061ef5187cfa..7752693765a1 100644 --- a/sc/inc/dbdata.hxx +++ b/sc/inc/dbdata.hxx @@ -262,7 +262,7 @@ public: Deletes p if it could not be inserted, i.e. duplicate name. @return <TRUE/> if inserted, else <FALSE/>. */ - SAL_WARN_UNUSED_RESULT bool insert(ScDBData* p); + bool insert(ScDBData* p); void erase(const iterator& itr); bool empty() const; |