diff options
| author | gilssonn <gilsonnyirimana@gmail.com> | 2023-07-13 23:11:11 -0400 |
|---|---|---|
| committer | Hossein <hossein@libreoffice.org> | 2024-01-03 22:01:37 +0100 |
| commit | 1cca19ad9701f4104ba6764802712387c29f28e3 (patch) | |
| tree | 0c351647b94309dee8d0742223e29641f3d30032 /sc/inc/document.hxx | |
| parent | b79056d2dae30a261e9bcf117d1f31fddf9bd8dd (diff) | |
tdf#114441 Convert use of sal_uLong to better integer types
Reasoning:
+ For clipcontent.cxx, column3.cxx, dbdocutl.cxx, documen8.cxx,formulacell.cxx,
patattr.cxx, stlpool.cxx, table2.cxx, table3.cxx and validat.cxx:
+ sal_uLong variables and functions are being
initialized with/assigned/returning sal_uInt32 or size_t values
+ For column2.cxx:
+ The type of the return values of the `getWeight` function are size_t
+ For document.hxx, documen2.cxx, docsh.hxx, docsh5.cxx, viewfun2.cxx and globstr.hrc
+ `ScDocument::TransferTab`'s return variable's value is constrained to be either 0 or 1; which is better represented as a boolean
Change-Id: If556f7fcc29f7e325618721959ea4e3615b2e755
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154408
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
Diffstat (limited to 'sc/inc/document.hxx')
| -rw-r--r-- | sc/inc/document.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index d94b0ef4fb53..03b070b3ed90 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -990,7 +990,7 @@ public: bool MoveTab( SCTAB nOldPos, SCTAB nNewPos, ScProgress* pProgress = nullptr ); SC_DLLPUBLIC bool CopyTab( SCTAB nOldPos, SCTAB nNewPos, const ScMarkData* pOnlyMarked = nullptr ); - SC_DLLPUBLIC sal_uLong TransferTab(ScDocument& rSrcDoc, SCTAB nSrcPos, SCTAB nDestPos, + SC_DLLPUBLIC bool TransferTab(ScDocument& rSrcDoc, SCTAB nSrcPos, SCTAB nDestPos, bool bInsertNew = true, bool bResultsOnly = false ); SC_DLLPUBLIC void TransferDrawPage(const ScDocument& rSrcDoc, SCTAB nSrcPos, SCTAB nDestPos); |