Revert "loplugin:constfields in sc"

This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675.

Now that we know that making fields has negative side effects
like disabling assignment operator generation.

Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 8 insertions, 8 deletions

diff --git a/sc/inc/dptabres.hxx b/sc/inc/dptabres.hxx
index 13eeb5fc5135..cdeb14779b43 100644
--- a/sc/inc/dptabres.hxx
+++ b/sc/inc/dptabres.hxx
@@ -58,8 +58,8 @@ class ScDPInitState
 public:
     struct Member
     {
-        long const mnSrcIndex;
-        SCROW const mnNameIndex;
+        long mnSrcIndex;
+        SCROW mnNameIndex;
 
         Member(long nSrcIndex, SCROW nNameIndex);
     };
@@ -123,8 +123,8 @@ public:
     void    RemoveRowIndex();
 
 private:
-    ScDPResultMember* const   pColResRoot;
-    ScDPResultMember* const   pRowResRoot;
+    ScDPResultMember*   pColResRoot;
+    ScDPResultMember*   pRowResRoot;
 
     mutable IndexArray maColVisible;
     mutable IndexArray maColSorted;
@@ -135,7 +135,7 @@ private:
 struct ScDPRelativePos
 {
     long    nBasePos;       // simple count, without sort order applied
-    long const    nDirection;
+    long    nDirection;
 
     ScDPRelativePos( long nBase, long nDir );
 };
@@ -247,7 +247,7 @@ private:
     const ::std::vector<ScDPDimension*>& mppDim;
     const ::std::vector<ScDPLevel*>& mppLev;
 
-    bool const mbRow:1;
+    bool mbRow:1;
     bool mbInitChild:1;
     bool mbAllChildren:1;
 public:
@@ -330,11 +330,11 @@ class ScDPResultMember
 {
 private:
     const ScDPResultData*   pResultData;
-    ScDPParentDimData const        aParentDimData;
+    ScDPParentDimData        aParentDimData;
     std::unique_ptr<ScDPResultDimension>  pChildDimension;
     std::unique_ptr<ScDPDataMember>       pDataRoot;
     bool                    bHasElements:1;
-    bool const              bForceSubTotal:1;
+    bool                    bForceSubTotal:1;
     bool                    bHasHiddenDetails:1;
     bool                    bInitialized:1;
     bool                    bAutoHidden:1;