diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2018-11-28 15:32:20 +0100 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2018-12-03 15:32:45 +0100 |
| commit | 99014ec9ded70a679220fe59e09ab4073512c249 (patch) | |
| tree | 7fab6d6e3a965bcbae8ae84514f894ff3c875f7b /sc/inc/formulacell.hxx | |
| parent | 1b489b74fe28007749bec8a3ebd56901a7652734 (diff) | |
make sure FetchVectorRefArray() never triggers Interpret()
Test::testFormulaRefUpdateRange could trigger this, leading to recursion
that wasn't handled properly by the code, since it wasn't expected
to happen at late time (ScDependantsCalculator should have already
caught it). This is all caused by the fact that FetchVectorRefArray()
fetches also all rows before the given rows (to make the caching simpler
I suppose). But that fetching could lead to Interpret() calls.
Therefore, make ScDependantsCalculator in OpenCL mode check also all
rows above.
Change-Id: Iaecc105663df21b01443759287cec605470d34a5
Reviewed-on: https://gerrit.libreoffice.org/64236
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'sc/inc/formulacell.hxx')
| -rw-r--r-- | sc/inc/formulacell.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx index f5b4da63b65c..f344b46034da 100644 --- a/sc/inc/formulacell.hxx +++ b/sc/inc/formulacell.hxx @@ -143,7 +143,7 @@ private: ScFormulaCell( const ScFormulaCell& ) = delete; - bool CheckComputeDependencies(sc::FormulaLogger::GroupScope& rScope); + bool CheckComputeDependencies(sc::FormulaLogger::GroupScope& rScope, bool fromFirstRow = false); bool InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope& aScope, bool& bDependencyComputed, bool& bDependencyCheckFailed); |