diff options
author | Dennis Francis <dennis.francis@collabora.co.uk> | 2018-11-08 10:38:07 +0530 |
---|---|---|
committer | Dennis Francis <dennis.francis@collabora.com> | 2018-11-14 15:50:26 +0100 |
commit | 1fb3d85aa855f57c3a4b32819d0acd9a378bd97c (patch) | |
tree | c509d32f0e5d625d0a7e99dcbcc0bd85f97362cd /sc/inc/formulacell.hxx | |
parent | 7374b8aceba8e7f6a89982844bcdc3a861bf0b49 (diff) |
Reorder ScFormulaCell members
When evaluating/getting result from a formulacell(which
has been evaluated before), first bDirty/bTableOpDirty
are accessed from MaybeInterpret()/NeedsInterpret(), then
aResult is accessed, so it makes sense to put the first
7 bools(with bDirty/bTableOpDirty) in the beginning, then
aResult, then rest of bools and other remaining members. The
expectation is that when bDirty is accessed in NeedsInterpret(),
the relevant contents of aResult is also fetched to cache
and remains there till aResult is needed.
Change-Id: Ide0d1e809ca045ef347520f26c4d3ab9faa994bb
Reviewed-on: https://gerrit.libreoffice.org/63065
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Diffstat (limited to 'sc/inc/formulacell.hxx')
-rw-r--r-- | sc/inc/formulacell.hxx | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx index 9434ed8087de..f5b4da63b65c 100644 --- a/sc/inc/formulacell.hxx +++ b/sc/inc/formulacell.hxx @@ -108,25 +108,14 @@ class SC_DLLPUBLIC ScFormulaCell : public SvtListener { private: ScFormulaCellGroupRef mxGroup; // Group of formulae we're part of - ScFormulaResult aResult; - formula::FormulaGrammar::Grammar eTempGrammar; // used between string (creation) and (re)compilation - ScTokenArray* pCode; // The (new) token array - ScDocument* pDocument; - ScFormulaCell* pPrevious; - ScFormulaCell* pNext; - ScFormulaCell* pPreviousTrack; - ScFormulaCell* pNextTrack; - sal_uInt16 nSeenInIteration; // Iteration cycle in which the cell was last encountered - SvNumFormatType nFormatType; - ScMatrixMode cMatrixFlag; bool bDirty : 1; // Must be (re)calculated + bool bTableOpDirty : 1; // Dirty flag for TableOp bool bChanged : 1; // Whether something changed regarding display/representation bool bRunning : 1; // Already interpreting right now bool bCompile : 1; // Must be (re)compiled bool bSubTotal : 1; // Cell is part of or contains a SubTotal bool bIsIterCell : 1; // Cell is part of a circular reference bool bInChangeTrack : 1; // Cell is in ChangeTrack - bool bTableOpDirty : 1; // Dirty flag for TableOp bool bNeedListening : 1; // Listeners need to be re-established after UpdateReference bool mbNeedsNumberFormat : 1; // set the calculated number format as hard number format bool mbAllowNumberFormatChange : 1; /* allow setting further calculated @@ -134,6 +123,17 @@ private: bool mbPostponedDirty : 1; // if cell needs to be set dirty later bool mbIsExtRef : 1; // has references in ScExternalRefManager; never cleared after set bool mbSeenInPath : 1; // For detecting cycle involving formula groups and singleton formulacells + ScMatrixMode cMatrixFlag : 8; + sal_uInt16 nSeenInIteration : 16; // Iteration cycle in which the cell was last encountered + SvNumFormatType nFormatType : 16; + ScFormulaResult aResult; + formula::FormulaGrammar::Grammar eTempGrammar; // used between string (creation) and (re)compilation + ScTokenArray* pCode; // The (new) token array + ScDocument* pDocument; + ScFormulaCell* pPrevious; + ScFormulaCell* pNext; + ScFormulaCell* pPreviousTrack; + ScFormulaCell* pNextTrack; /** * Update reference in response to cell copy-n-paste. |