summaryrefslogtreecommitdiff
path: root/sc/inc/scdllapi.h
diff options
context:
space:
mode:
authorLuboš Luňák <l.lunak@collabora.com>2019-02-12 13:48:53 +0100
committerChristian Lohmaier <lohmaier+LibreOffice@googlemail.com>2019-03-04 16:50:25 +0100
commitc22ef33f673beb65e24f581ad61ec93807d97085 (patch)
treee5e53c5479ff58e7a04ed4deaf451fd2ec2dfee7 /sc/inc/scdllapi.h
parentac44b07f7ad305fe73c070ce38913b1578cc211a (diff)
reintroduce ScCaptionPtr
This basically reverts b6b1ded0a0539e7be1b5338de378a3276a6ff445, since it introduces tdf#118707, and I cannot reproduce any of the original problems when reverting. The patch itself is technically correct, but the problem is in the Windows implementation of clipboard handling, which uses delayed processing of setting clipboard contents. This leads to previous clipboard contents being deleted too late, and with shared_ptr instances of SdrCaptionObj may get deleted after the related SdrModel has already been deleted. A proper fix would be to remove the stupid delayed processing from the clipboard code, but that's non-trivial. If that gets fixed, the change removing ScCaptionPtr may most probably be applied again. Change-Id: I29634847486aa955b20483c9eb38bba4fed87187 Reviewed-on: https://gerrit.libreoffice.org/67725 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/68685 Reviewed-by: Eike Rathke <erack@redhat.com>
Diffstat (limited to 'sc/inc/scdllapi.h')
0 files changed, 0 insertions, 0 deletions