clang-tidy performance-unnecessary-value-param in sc

Change-Id: Ia2255e1e3f7a8834a4b5d2a6bbab2c6dd498d356

5 files changed, 6 insertions, 6 deletions

diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx
index 2d0536bcfdd6..f4ed5e92835f 100644
--- a/sc/inc/conditio.hxx
+++ b/sc/inc/conditio.hxx
@@ -107,7 +107,7 @@ public:
     void resetTokenArray(ScTokenArray* pTokens, const ScRange& rRange);
     void addTokenArray(ScTokenArray* pTokens, const ScRange& rRange);
     void stopListening();
-    void setCallback(std::function<void()> aCallbackFunction);
+    void setCallback(const std::function<void()>& aCallbackFunction);
 };
 
 class ScConditionalFormat;
diff --git a/sc/inc/dbdata.hxx b/sc/inc/dbdata.hxx
index 6778a94f338e..23146636de65 100644
--- a/sc/inc/dbdata.hxx
+++ b/sc/inc/dbdata.hxx
@@ -259,7 +259,7 @@ public:
         iterator findByUpperName2(const OUString& rName);
         // Takes ownership of p iff it returns true:
         SAL_WARN_UNUSED_RESULT bool insert(ScDBData* p);
-        void erase(iterator itr);
+        void erase(const iterator& itr);
         bool empty() const;
         size_t size() const;
         bool operator== (const NamedDBs& r) const;
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index bbb525bb93e7..ac4f6c5cc0bc 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -805,12 +805,12 @@ public:
     /** Tries to find a DDE link or creates a new, if not extant.
         @param pResults  If not 0, sets the matrix as DDE link result matrix (also for existing links).
         @return  true = DDE link found; false = Unpredictable error occurred, no DDE link created. */
-    SC_DLLPUBLIC bool            CreateDdeLink( const OUString& rAppl, const OUString& rTopic, const OUString& rItem, sal_uInt8 nMode, ScMatrixRef pResults );
+    SC_DLLPUBLIC bool            CreateDdeLink( const OUString& rAppl, const OUString& rTopic, const OUString& rItem, sal_uInt8 nMode, const ScMatrixRef& pResults );
     /** Sets a result matrix for the specified DDE link.
         @param nDdePos  Index of the DDE link (does not include other links from link manager).
         @param pResults  The array containing all results of the DDE link (intrusive-ref-counted, do not delete).
         @return  true = DDE link found and matrix set. */
-    bool            SetDdeLinkResultMatrix( size_t nDdePos, ScMatrixRef pResults );
+    bool            SetDdeLinkResultMatrix( size_t nDdePos, const ScMatrixRef& pResults );
 
     SfxBindings*    GetViewBindings();
     SfxObjectShell* GetDocumentShell() const    { return pShell; }
diff --git a/sc/inc/olinetab.hxx b/sc/inc/olinetab.hxx
index 6b4824402a1f..02f4d701d862 100644
--- a/sc/inc/olinetab.hxx
+++ b/sc/inc/olinetab.hxx
@@ -79,7 +79,7 @@ public:
     iterator end();
     const_iterator begin() const;
     const_iterator end() const;
-    void erase(iterator pos);
+    void erase(const iterator& pos);
     bool empty() const;
 
     iterator FindStart(SCCOLROW nMinStart);
diff --git a/sc/inc/userlist.hxx b/sc/inc/userlist.hxx
index b103aeec97d0..3c0752aec50a 100644
--- a/sc/inc/userlist.hxx
+++ b/sc/inc/userlist.hxx
@@ -87,7 +87,7 @@ public:
     void clear();
     size_t size() const;
     void push_back(ScUserListData* p);
-    void erase(iterator itr);
+    void erase(const iterator& itr);
 };
 
 #endif