new compilerplugin returnbyref

Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7

5 files changed, 10 insertions, 10 deletions

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 5d6cc276153b..368e644c3b44 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -2024,8 +2024,8 @@ public:
 
     ScRefreshTimerControl*  GetRefreshTimerControl() const
         { return pRefreshTimerControl; }
-    ScRefreshTimerControl * const * GetRefreshTimerControlAddress() const
-        { return &pRefreshTimerControl; }
+    ScRefreshTimerControl * const & GetRefreshTimerControlAddress() const
+        { return pRefreshTimerControl; }
 
     void            SetPastingDrawFromOtherDoc( bool bVal )
                         { bPastingDrawFromOtherDoc = bVal; }
diff --git a/sc/inc/dpfilteredcache.hxx b/sc/inc/dpfilteredcache.hxx
index ba578d2b5262..0587b32d78af 100644
--- a/sc/inc/dpfilteredcache.hxx
+++ b/sc/inc/dpfilteredcache.hxx
@@ -106,7 +106,7 @@ public:
     sal_Int32 getRowSize() const;
     sal_Int32 getColSize() const;
 
-    const ScDPCache* getCache() const { return &mrCache;}
+    const ScDPCache& getCache() const { return mrCache;}
 
     void fillTable(const ScQueryParam& rQuery, bool bIgnoreEmptyRows, bool bRepeatIfEmpty);
 
diff --git a/sc/inc/externalrefmgr.hxx b/sc/inc/externalrefmgr.hxx
index 78176fbc94f5..9b73b4a73ee3 100644
--- a/sc/inc/externalrefmgr.hxx
+++ b/sc/inc/externalrefmgr.hxx
@@ -767,7 +767,7 @@ private:
     /**
      * Caller must ensure that the passed shell is not already stored.
      */
-    ScDocument* cacheNewDocShell( sal_uInt16 nFileId, SrcShell& rSrcShell );
+    ScDocument& cacheNewDocShell( sal_uInt16 nFileId, SrcShell& rSrcShell );
 
     void maybeLinkExternalFile(sal_uInt16 nFileId);
 
diff --git a/sc/inc/olinetab.hxx b/sc/inc/olinetab.hxx
index a0df79d56a95..0312c6f3fefe 100644
--- a/sc/inc/olinetab.hxx
+++ b/sc/inc/olinetab.hxx
@@ -151,10 +151,10 @@ public:
                             ScOutlineTable();
                             ScOutlineTable( const ScOutlineTable& rOutline );
 
-    const ScOutlineArray*   GetColArray() const     { return &aColOutline; }
-    ScOutlineArray*         GetColArray()           { return &aColOutline; }
-    const ScOutlineArray*   GetRowArray() const     { return &aRowOutline; }
-    ScOutlineArray*         GetRowArray()           { return &aRowOutline; }
+    const ScOutlineArray&   GetColArray() const     { return aColOutline; }
+    ScOutlineArray&         GetColArray()           { return aColOutline; }
+    const ScOutlineArray&   GetRowArray() const     { return aRowOutline; }
+    ScOutlineArray&         GetRowArray()           { return aRowOutline; }
 
     bool                    TestInsertCol( SCSIZE nSize );
     void                    InsertCol( SCCOL nStartCol, SCSIZE nSize );
diff --git a/sc/inc/refreshtimerprotector.hxx b/sc/inc/refreshtimerprotector.hxx
index 3ca5568411a7..743643a48b28 100644
--- a/sc/inc/refreshtimerprotector.hxx
+++ b/sc/inc/refreshtimerprotector.hxx
@@ -17,10 +17,10 @@ class ScRefreshTimerControl;
 
 class SC_DLLPUBLIC ScRefreshTimerProtector
 {
-    ScRefreshTimerControl * const * ppControl;
+    ScRefreshTimerControl * const & m_rpControl;
 
 public:
-    ScRefreshTimerProtector( ScRefreshTimerControl * const * pp );
+    ScRefreshTimerProtector( ScRefreshTimerControl * const & rp );
     ~ScRefreshTimerProtector();
 };