loplugin:constantparam in sc

Change-Id: I82c78dd880c98532db407b0183a43705be2de67c
Reviewed-on: https://gerrit.libreoffice.org/28777
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

9 files changed, 14 insertions, 23 deletions

diff --git a/sc/inc/bulkdatahint.hxx b/sc/inc/bulkdatahint.hxx
index 4b375848f87b..dd82ef6d3b9e 100644
--- a/sc/inc/bulkdatahint.hxx
+++ b/sc/inc/bulkdatahint.hxx
@@ -28,7 +28,7 @@ class BulkDataHint : public SfxSimpleHint
     BulkDataHint& operator= ( const BulkDataHint& ) = delete;
 
 public:
-    BulkDataHint( ScDocument& rDoc, const ColumnSpanSet* pSpans );
+    BulkDataHint( ScDocument& rDoc );
     virtual ~BulkDataHint();
 
     void setSpans( const ColumnSpanSet* pSpans );
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 35c737d40882..af73ff0c03b4 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -350,7 +350,7 @@ public:
 
     void CloneFormulaCell(
         const ScFormulaCell& rSrc, const sc::CellTextAttr& rAttr,
-        const std::vector<sc::RowSpan>& rRanges, sc::StartListeningContext* pCxt );
+        const std::vector<sc::RowSpan>& rRanges );
 
     svl::SharedString GetSharedString( SCROW nRow ) const;
 
diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx
index 1faf6bc331fe..08718960af01 100644
--- a/sc/inc/conditio.hxx
+++ b/sc/inc/conditio.hxx
@@ -278,7 +278,7 @@ public:
     bool NeedsRepaint() const;
 
 protected:
-    virtual void    DataChanged( const ScRange* pModified ) const;
+    virtual void    DataChanged() const;
     ScDocument*     GetDocument() const     { return mpDoc; }
     ScConditionalFormat*    pCondFormat;
 
@@ -344,7 +344,7 @@ public:
     virtual ScFormatEntry* Clone(ScDocument* pDoc) const override;
 
 protected:
-    virtual void    DataChanged( const ScRange* pModified ) const override;
+    virtual void    DataChanged() const override;
 };
 
 namespace condformat {
diff --git a/sc/inc/dapiuno.hxx b/sc/inc/dapiuno.hxx
index d58e53d586a4..162d86d173e3 100644
--- a/sc/inc/dapiuno.hxx
+++ b/sc/inc/dapiuno.hxx
@@ -367,15 +367,15 @@ public:
 
 struct ScFieldIdentifier
 {
-    OUString     maFieldName;    /// Source field name.
+    OUString            maFieldName;    /// Source field name.
     sal_Int32           mnFieldIdx;     /// Field index (if several fields with same name exist).
     bool                mbDataLayout;   /// True = data layout field collecting all data fields as items.
 
     inline explicit     ScFieldIdentifier() :
                             mnFieldIdx( 0 ), mbDataLayout( false ) {}
 
-    inline explicit     ScFieldIdentifier( const OUString& rFieldName, sal_Int32 nFieldIdx, bool bDataLayout ) :
-                            maFieldName( rFieldName ), mnFieldIdx( nFieldIdx ), mbDataLayout( bDataLayout ) {}
+    inline explicit     ScFieldIdentifier( const OUString& rFieldName, bool bDataLayout ) :
+                            maFieldName( rFieldName ), mnFieldIdx( 0 ), mbDataLayout( bDataLayout ) {}
 };
 
 /** Base class of all implementation objects based on a DataPilot descriptor
diff --git a/sc/inc/docpool.hxx b/sc/inc/docpool.hxx
index 9536bb8c787f..deaaa6bd4ba3 100644
--- a/sc/inc/docpool.hxx
+++ b/sc/inc/docpool.hxx
@@ -30,7 +30,6 @@ class ScDocument;
 class SC_DLLPUBLIC ScDocumentPool: public SfxItemPool
 {
     SfxPoolItem**   ppPoolDefaults;
-    SfxItemPool*    pSecondary;
     static sal_uInt16*  pVersionMap1;
     static sal_uInt16*  pVersionMap2;
     static sal_uInt16*  pVersionMap3;
@@ -45,7 +44,7 @@ class SC_DLLPUBLIC ScDocumentPool: public SfxItemPool
     static sal_uInt16*  pVersionMap12;
 
 public:
-            ScDocumentPool( SfxItemPool* pSecPool = nullptr );
+            ScDocumentPool();
 protected:
             virtual ~ScDocumentPool();
 public:
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 57ab3128e5ee..289d6df8a8f0 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1857,7 +1857,7 @@ public:
         SCTAB nTab, const ScSortParam& rSortParam, bool bKeepQuery, bool bUpdateRefs,
         ScProgress* pProgress, sc::ReorderParam* pUndo );
 
-    void Reorder( const sc::ReorderParam& rParam, ScProgress* pProgress );
+    void Reorder( const sc::ReorderParam& rParam );
 
     SCSIZE          Query( SCTAB nTab, const ScQueryParam& rQueryParam, bool bKeepSub );
     SC_DLLPUBLIC bool           CreateQueryParam( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2,
diff --git a/sc/inc/patattr.hxx b/sc/inc/patattr.hxx
index a3fcf887310c..626e3ddef6b9 100644
--- a/sc/inc/patattr.hxx
+++ b/sc/inc/patattr.hxx
@@ -54,7 +54,7 @@ class SC_DLLPUBLIC ScPatternAttr: public SfxSetItem
     ScStyleSheet*   pStyle;
 public:
                             ScPatternAttr(SfxItemSet* pItemSet, const OUString& rStyleName);
-                            ScPatternAttr(SfxItemSet* pItemSet, ScStyleSheet* pStyleSheet = nullptr);
+                            ScPatternAttr(SfxItemSet* pItemSet);
                             ScPatternAttr(SfxItemPool* pItemPool);
                             ScPatternAttr(const ScPatternAttr& rPatternAttr);
 
diff --git a/sc/inc/rangelst.hxx b/sc/inc/rangelst.hxx
index 64216efec531..783dd44bd552 100644
--- a/sc/inc/rangelst.hxx
+++ b/sc/inc/rangelst.hxx
@@ -39,7 +39,6 @@ public:
     void Append( const ScRange& rRange );
 
     ScRefFlags Parse( const OUString&, ScDocument*,
-                      ScRefFlags nMask = ScRefFlags::VALID,
                       formula::FormulaGrammar::AddressConvention eConv = formula::FormulaGrammar::CONV_OOO,
                       SCTAB nDefaultTab = 0, sal_Unicode cDelimiter = 0 );
 
diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index d78f4e600266..b601d5fe11fd 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -341,8 +341,7 @@ public:
 
     virtual AbstractScSortWarningDlg * CreateScSortWarningDlg(vcl::Window* pParent, const OUString& rExtendText, const OUString& rCurrentText ) = 0;
 
-    virtual AbstractScCondFormatManagerDlg* CreateScCondFormatMgrDlg(vcl::Window* pParent, ScDocument* pDoc, const ScConditionalFormatList* pFormatList,
-                                                                int nId ) = 0;
+    virtual AbstractScCondFormatManagerDlg* CreateScCondFormatMgrDlg(vcl::Window* pParent, ScDocument* pDoc, const ScConditionalFormatList* pFormatList ) = 0;
 
     virtual AbstractScDataPilotDatabaseDlg * CreateScDataPilotDatabaseDlg(vcl::Window* pParent) = 0;
 
@@ -350,8 +349,7 @@ public:
         bool bEnableExternal) = 0;
 
     virtual AbstractScDataPilotServiceDlg * CreateScDataPilotServiceDlg( vcl::Window* pParent,
-                                                                        const std::vector<OUString>& rServices,
-                                                                        int nId ) = 0;
+                                                                        const std::vector<OUString>& rServices ) = 0;
 
     virtual AbstractScDeleteCellDlg * CreateScDeleteCellDlg(vcl::Window* pParent, bool bDisallowCellMove) = 0 ;
 
@@ -374,7 +372,6 @@ public:
                                                             bool bUnGroup = false ) = 0;
 
     virtual AbstractScInsertCellDlg * CreateScInsertCellDlg( vcl::Window* pParent,
-                                                             int nId,
                                                              bool bDisallowCellMove ) = 0;
 
     virtual AbstractScInsertContentsDlg * CreateScInsertContentsDlg( vcl::Window*        pParent,
@@ -394,9 +391,7 @@ public:
                                                                 FieldUnit       eFUnit,
                                                                 sal_uInt16      nDecimals = 2,
                                                                 long            nMaximum  = 1000,
-                                                                long            nMinimum  = 0,
-                                                                long            nFirst    = 1,
-                                                                long            nLast     = 100 ) = 0;
+                                                                long            nMinimum  = 0 ) = 0;
 
     virtual AbstractScMoveTableDlg * CreateScMoveTableDlg(vcl::Window * pParent,
         const OUString& rDefault) = 0;
@@ -421,16 +416,14 @@ public:
                                                                 const ScDPNameVec& rDataFields ) = 0;
 
     virtual AbstractScDPNumGroupDlg * CreateScDPNumGroupDlg( vcl::Window* pParent,
-                                                                int nId,
                                                                 const ScDPNumGroupInfo& rInfo ) = 0;
 
     virtual AbstractScDPDateGroupDlg * CreateScDPDateGroupDlg( vcl::Window* pParent,
-                                                                int nId,
                                                                 const ScDPNumGroupInfo& rInfo,
                                                                 sal_Int32 nDatePart,
                                                                 const Date& rNullDate ) = 0;
 
-    virtual AbstractScDPShowDetailDlg * CreateScDPShowDetailDlg( vcl::Window* pParent, int nId,
+    virtual AbstractScDPShowDetailDlg * CreateScDPShowDetailDlg( vcl::Window* pParent,
                                                                 ScDPObject& rDPObj,
                                                                 sal_uInt16 nOrient ) = 0;