new loplugin: change virtual methods to non-virtual

Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae

10 files changed, 22 insertions, 22 deletions

diff --git a/sc/inc/attrib.hxx b/sc/inc/attrib.hxx
index 8c86e0ea3e48..5aca8a3ba5b5 100644
--- a/sc/inc/attrib.hxx
+++ b/sc/inc/attrib.hxx
@@ -56,7 +56,7 @@ public:
                 ScMergeAttr( const ScMergeAttr& );
                 virtual ~ScMergeAttr();
 
-    virtual OUString        GetValueText() const;
+    OUString        GetValueText() const;
 
     virtual bool            operator==( const SfxPoolItem& ) const SAL_OVERRIDE;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = 0 ) const SAL_OVERRIDE;
@@ -110,7 +110,7 @@ public:
                             ScProtectionAttr( const ScProtectionAttr& );
                             virtual ~ScProtectionAttr();
 
-    virtual OUString            GetValueText() const;
+    OUString            GetValueText() const;
     virtual bool GetPresentation(
                                     SfxItemPresentation ePres,
                                     SfxMapUnit eCoreMetric,
@@ -251,7 +251,7 @@ public:
                 ScPageHFItem( const ScPageHFItem& rItem );
                 virtual ~ScPageHFItem();
 
-    virtual OUString        GetValueText() const;
+    OUString        GetValueText() const;
     virtual bool            operator==( const SfxPoolItem& ) const SAL_OVERRIDE;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = 0 ) const SAL_OVERRIDE;
 
@@ -284,7 +284,7 @@ public:
                 virtual ~ScViewObjectModeItem();
 
     virtual sal_uInt16              GetValueCount() const SAL_OVERRIDE;
-    virtual OUString            GetValueText( sal_uInt16 nVal ) const;
+    OUString            GetValueText( sal_uInt16 nVal ) const;
     virtual SfxPoolItem*        Clone( SfxItemPool *pPool = 0 ) const SAL_OVERRIDE;
     virtual SfxPoolItem*        Create(SvStream &, sal_uInt16) const SAL_OVERRIDE;
     virtual sal_uInt16              GetVersion( sal_uInt16 nFileVersion ) const SAL_OVERRIDE;
@@ -303,7 +303,7 @@ public:
                 ScDoubleItem( const ScDoubleItem& rItem );
                 virtual ~ScDoubleItem();
 
-    virtual OUString        GetValueText() const;
+    OUString        GetValueText() const;
     virtual bool            operator==( const SfxPoolItem& ) const SAL_OVERRIDE;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = 0 ) const SAL_OVERRIDE;
 
diff --git a/sc/inc/cellsuno.hxx b/sc/inc/cellsuno.hxx
index 12653280f607..d733a932f68a 100644
--- a/sc/inc/cellsuno.hxx
+++ b/sc/inc/cellsuno.hxx
@@ -219,7 +219,7 @@ protected:
 
     // GetItemPropertyMap for derived classes must contain all entries, including base class
     virtual const SfxItemPropertyMap& GetItemPropertyMap();
-    virtual ::com::sun::star::beans::PropertyState GetOnePropertyState(
+    ::com::sun::star::beans::PropertyState GetOnePropertyState(
                                 sal_uInt16 nItemWhich, const SfxItemPropertySimpleEntry* pEntry );
     virtual void            GetOnePropertyValue( const SfxItemPropertySimpleEntry* pEntry,
                                 ::com::sun::star::uno::Any& )
@@ -674,7 +674,7 @@ public:
     virtual void            RefChanged() SAL_OVERRIDE;
 
                             // via getImplementation()
-    virtual void            SetArrayFormulaWithGrammar( const OUString& rFormula,
+    void            SetArrayFormulaWithGrammar( const OUString& rFormula,
                                     const OUString& rFormulaNmsp,
                                     const formula::FormulaGrammar::Grammar )
                                 throw (css::uno::RuntimeException,
diff --git a/sc/inc/defaultsoptions.hxx b/sc/inc/defaultsoptions.hxx
index e87f61697eba..22513598210b 100644
--- a/sc/inc/defaultsoptions.hxx
+++ b/sc/inc/defaultsoptions.hxx
@@ -51,7 +51,7 @@ public:
     ScTpDefaultsItem( const ScTpDefaultsItem& rItem );
     virtual ~ScTpDefaultsItem();
 
-    virtual OUString        GetValueText() const;
+    OUString        GetValueText() const;
     virtual bool            operator==( const SfxPoolItem& ) const SAL_OVERRIDE;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = 0 ) const SAL_OVERRIDE;
 
diff --git a/sc/inc/docoptio.hxx b/sc/inc/docoptio.hxx
index 9e06437fb65c..30f3ec1a4523 100644
--- a/sc/inc/docoptio.hxx
+++ b/sc/inc/docoptio.hxx
@@ -151,7 +151,7 @@ public:
                 ScTpCalcItem( const ScTpCalcItem& rItem );
                 virtual ~ScTpCalcItem();
 
-    virtual OUString        GetValueText() const;
+    OUString        GetValueText() const;
     virtual bool            operator==( const SfxPoolItem& ) const SAL_OVERRIDE;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = 0 ) const SAL_OVERRIDE;
 
diff --git a/sc/inc/dptabdat.hxx b/sc/inc/dptabdat.hxx
index 9030090939ba..0b284efce4d7 100644
--- a/sc/inc/dptabdat.hxx
+++ b/sc/inc/dptabdat.hxx
@@ -114,7 +114,7 @@ public:
     virtual bool                    getIsDataLayoutDimension(long nColumn) = 0;
     virtual bool                    IsDateDimension(long nDim) = 0;
     virtual sal_uLong               GetNumberFormat(long nDim);
-    virtual sal_uInt32              GetNumberFormatByIdx( NfIndexTableOffset );
+    sal_uInt32              GetNumberFormatByIdx( NfIndexTableOffset );
     virtual void                    DisposeData() = 0;
     virtual void                    SetEmptyFlags( bool bIgnoreEmptyRows, bool bRepeatIfEmpty ) = 0;
 
@@ -139,7 +139,7 @@ public:
                                                       const ScDPItemData& rSecondData, long nSecondIndex ) const;
 
     virtual long                            GetMembersCount( long nDim );
-    virtual const ScDPItemData*   GetMemberByIndex( long nDim, long nIndex );
+    const ScDPItemData*   GetMemberByIndex( long nDim, long nIndex );
     virtual const ScDPItemData*   GetMemberById( long nDim, long nId);
     virtual long                GetSourceDim( long nDim );
     virtual long                Compare( long nDim, long nDataId1, long nDataId2);
diff --git a/sc/inc/dptabsrc.hxx b/sc/inc/dptabsrc.hxx
index 5f0b9eb1a6c7..016e7090663d 100644
--- a/sc/inc/dptabsrc.hxx
+++ b/sc/inc/dptabsrc.hxx
@@ -306,8 +306,8 @@ public:
     virtual ::com::sun::star::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
                                 throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 
-    virtual long            getCount() const;
-    virtual ScDPDimension*  getByIndex(long nIndex) const;
+    long            getCount() const;
+    ScDPDimension*  getByIndex(long nIndex) const;
 };
 
 class ScDPDimension : boost::noncopyable, public cppu::WeakImplHelper5<
@@ -460,8 +460,8 @@ public:
     virtual ::com::sun::star::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
                                 throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 
-    virtual long            getCount() const;
-    virtual ScDPHierarchy*  getByIndex(long nIndex) const;
+    long            getCount() const;
+    ScDPHierarchy*  getByIndex(long nIndex) const;
 };
 
 class ScDPHierarchy : public cppu::WeakImplHelper3<
@@ -537,8 +537,8 @@ public:
     virtual ::com::sun::star::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
                                 throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 
-    virtual long            getCount() const;
-    virtual ScDPLevel*      getByIndex(long nIndex) const;
+    long            getCount() const;
+    ScDPLevel*      getByIndex(long nIndex) const;
 };
 
 class ScDPLevel : public cppu::WeakImplHelper5<
diff --git a/sc/inc/formulaopt.hxx b/sc/inc/formulaopt.hxx
index 906804efee84..eceddc0d9e5d 100644
--- a/sc/inc/formulaopt.hxx
+++ b/sc/inc/formulaopt.hxx
@@ -87,7 +87,7 @@ public:
     ScTpFormulaItem( const ScTpFormulaItem& rItem );
     virtual ~ScTpFormulaItem();
 
-    virtual OUString        GetValueText() const;
+    OUString        GetValueText() const;
     virtual bool            operator==( const SfxPoolItem& ) const SAL_OVERRIDE;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = 0 ) const SAL_OVERRIDE;
 
diff --git a/sc/inc/nameuno.hxx b/sc/inc/nameuno.hxx
index b250b818f47f..fa46ca59cd30 100644
--- a/sc/inc/nameuno.hxx
+++ b/sc/inc/nameuno.hxx
@@ -197,10 +197,10 @@ protected:
 
     ScDocShell*             pDocShell;
     /** called from the XActionLockable interface methods on initial locking */
-    virtual void            lock();
+    void            lock();
 
     /** called from the XActionLockable interface methods on final unlock */
-    virtual void            unlock();
+    void            unlock();
 
 public:
                             ScNamedRangesObj(ScDocShell* pDocSh);
diff --git a/sc/inc/printopt.hxx b/sc/inc/printopt.hxx
index f6372e67f403..ed7e14f78b66 100644
--- a/sc/inc/printopt.hxx
+++ b/sc/inc/printopt.hxx
@@ -61,7 +61,7 @@ public:
                 ScTpPrintItem( const ScTpPrintItem& rItem );
                 virtual ~ScTpPrintItem();
 
-    virtual OUString        GetValueText() const;
+    OUString        GetValueText() const;
     virtual bool            operator==( const SfxPoolItem& ) const SAL_OVERRIDE;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = 0 ) const SAL_OVERRIDE;
 
diff --git a/sc/inc/viewopti.hxx b/sc/inc/viewopti.hxx
index ddef65e3bd45..1dc47a1d1f1e 100644
--- a/sc/inc/viewopti.hxx
+++ b/sc/inc/viewopti.hxx
@@ -120,7 +120,7 @@ public:
                 ScTpViewItem( const ScTpViewItem&  rItem );
                 virtual ~ScTpViewItem();
 
-    virtual OUString        GetValueText() const;
+    OUString        GetValueText() const;
     virtual bool            operator==( const SfxPoolItem& ) const SAL_OVERRIDE;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = 0 ) const SAL_OVERRIDE;