diff options
| author | Dennis Francis <dennis.francis@collabora.com> | 2019-04-10 04:30:25 +0530 |
|---|---|---|
| committer | Dennis Francis <dennis.francis@collabora.com> | 2019-04-12 00:48:38 +0200 |
| commit | 238cadd315901cbacfd9304bb1205e9f53f13eae (patch) | |
| tree | 361cbbe5d5cfe3d191bee861ed60988857139f8e /sc/inc | |
| parent | 9be7991df15da9d4d954eeac1ec342ad1a2b7467 (diff) | |
dpcache : use case-insensitive normalization of...
field labels, else on export to xlsx,
Excel will fail to load the pivot table due to case-insensitive
duplicate field labels in the pivotCacheDefinition1.xml.
This could be done just for xlsx export filter, but we do normalization
in dpcache.cxx anyway and it would not hurt if we do a case-insensitive
normalization here.
The private member ScDPCache::AddLabel had code duplication and
more importantly it is called in loop for every label in the database
so results in O(n^2) time complexity where n is the number of labels,
so removed it to reuse normalizeLabels() at the only call-site.
Also added a unit test that checks case-insensitive normalization.
Change-Id: Id563dee232a98a2aea9f4fc29254f6942e1c5ba7
Reviewed-on: https://gerrit.libreoffice.org/70498
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Diffstat (limited to 'sc/inc')
| -rw-r--r-- | sc/inc/dpcache.hxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sc/inc/dpcache.hxx b/sc/inc/dpcache.hxx index 1c88c14fff7e..1d1559755369 100644 --- a/sc/inc/dpcache.hxx +++ b/sc/inc/dpcache.hxx @@ -209,7 +209,6 @@ public: private: void PostInit(); void Clear(); - void AddLabel(const OUString& rLabel); const GroupItems* GetGroupItems(long nDim) const; }; |