diff options
| author | Kohei Yoshida <kohei.yoshida@gmail.com> | 2013-01-03 15:38:14 -0500 |
|---|---|---|
| committer | Kohei Yoshida <kohei.yoshida@gmail.com> | 2013-01-03 15:45:16 -0500 |
| commit | a39ceea669d964aab16378a7555b07f70d1f069d (patch) | |
| tree | b6db0e40e8669c39611c7ca7aa603fff6a68064f /sc/inc | |
| parent | 0e213aae481cbf7106bf13350835c9c488b035df (diff) | |
fdo#58004: Fix out-of-bound access to std::vector.
Two things were wrong with the old code:
1) it didn't check for out-of-bound access, and
2) used SC_DP_MAX_FIELDS as the upper bound of dimension members, when
in fact SC_DP_MAX_FIELDS was the upper bound of dimensions themselves,.
not their members. We shouldn't impose such upper bounds actually,
at least not in the core implementation. We should do that in the
UI code if we really have to.
Change-Id: I307d4f34d2b0be84f0fd2b93a6270ffce2448bdf
Diffstat (limited to 'sc/inc')
| -rw-r--r-- | sc/inc/dptabres.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/inc/dptabres.hxx b/sc/inc/dptabres.hxx index b49ee2c65283..81c3c01ab262 100644 --- a/sc/inc/dptabres.hxx +++ b/sc/inc/dptabres.hxx @@ -294,7 +294,7 @@ private: bool bDataAtRow:1; //! add "displayed values" settings - mutable std::vector< ResultMembers* > mpDimMembers; + mutable std::vector<ResultMembers*> maDimMembers; public: ScDPResultData( ScDPSource* pSrc ); //! Ref ~ScDPResultData(); |