diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-10 09:40:19 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-10 10:38:23 +0200 |
| commit | e9586cf0b5fda0092fdca3ab4db470e8fd765adf (patch) | |
| tree | e0340048f9eff52dd72ded1de84324fd6ae211b2 /sc/inc | |
| parent | 77e2d29bce92639498324814be56656f85a0f0fd (diff) | |
loplugin:unusedfield improvements
improve the read-only check to ignore reads from fields that are guarded
by a boolean check, something like:
if (field)
field.foo();
this produces some false positives at the moment because I'm not
correctly handling the else block, but also some useful new dead code.
Change-Id: Id21fa1a56c171d09d979769b978b6eef14e8b695
Reviewed-on: https://gerrit.libreoffice.org/52664
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/inc')
| -rw-r--r-- | sc/inc/chartlis.hxx | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/sc/inc/chartlis.hxx b/sc/inc/chartlis.hxx index 2537e15613d2..38642699f3dd 100644 --- a/sc/inc/chartlis.hxx +++ b/sc/inc/chartlis.hxx @@ -69,7 +69,6 @@ private: ScDocument* mpDoc; bool bUsed:1; // for ScChartListenerCollection::FreeUnused bool bDirty:1; - bool bSeriesRangesScheduled:1; ScChartListener& operator=( const ScChartListener& ) = delete; @@ -105,8 +104,6 @@ public: void UpdateChartIntersecting( const ScRange& rRange ); - // if chart series ranges are to be updated later on (e.g. DeleteTab, InsertTab) - void UpdateScheduledSeriesRanges(); void UpdateSeriesRanges(); ExternalRefListener* GetExtRefListener(); @@ -190,7 +187,6 @@ public: void SetRangeDirty( const ScRange& rRange ); // for example rows/columns - void UpdateScheduledSeriesRanges(); void UpdateChartsContainingTab( SCTAB nTab ); bool operator==( const ScChartListenerCollection& r ) const; |