diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2020-04-08 09:26:38 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2020-04-08 11:33:46 +0200 |
commit | 68c3d3e46bf731c93fe5eca2e35042484f77d650 (patch) | |
tree | 8f91e931df4e6024e5df45e99bea170798395b5f /sc/qa/uitest/calc_tests2 | |
parent | 92f1626160b823f8136c03ab067136f866279da9 (diff) |
Make SalInstance::CreateClipboard return a single instance in the non-LOK case
I came across this when seeing UITest_calc_tests2's
tdf118189.tdf118189.test_tdf118189 fail on Linux with SAL_USE_VCLPLUGIN=gen and
also on Windows, see the mailing list thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2020-April/084822.html>
"Linux SAL_USE_VCLPLUGIN=svp and the clipboard". That email thread clarified
that the codified behavior of that non-LOK test was wrong. (While the LOK test
ScTiledRenderingTest::testMultiViewCopyPaste in
sc/qa/unit/tiledrendering/tiledrendering.cxx keeps working as intended.)
I did not find documentation for what arguments CreateClipboard shall support,
but things seem to work if anything but empty arguments is rejected with an
IllegalArgumentException.
Change-Id: I1918254cc15878ad43b8aa22aff7eb1c4bea73fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91869
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'sc/qa/uitest/calc_tests2')
-rw-r--r-- | sc/qa/uitest/calc_tests2/tdf118189.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/qa/uitest/calc_tests2/tdf118189.py b/sc/qa/uitest/calc_tests2/tdf118189.py index ed33b20bcbee..e49a471fd40a 100644 --- a/sc/qa/uitest/calc_tests2/tdf118189.py +++ b/sc/qa/uitest/calc_tests2/tdf118189.py @@ -46,7 +46,7 @@ class tdf118189(UITestCase): self.xUITest.executeCommand(".uno:Undo") #-> CRASH - self.assertEqual(get_cell_by_position(document2, 0, 0, 0).getString(), "") + self.assertEqual(get_cell_by_position(document2, 0, 0, 0).getString(), "On Back Order") self.ui_test.close_doc() |