summaryrefslogtreecommitdiff
path: root/sc/qa/uitest/calc_tests4/tdf138089.py
diff options
context:
space:
mode:
authorXisco Fauli <xiscofauli@libreoffice.org>2021-06-21 16:21:30 +0200
committerXisco Fauli <xiscofauli@libreoffice.org>2021-06-22 14:46:39 +0200
commitbe0a41679fea524e0935dc6617b5e65349812dd1 (patch)
treef14372226d5054c045f954e38ea09da5c412215b /sc/qa/uitest/calc_tests4/tdf138089.py
parent14069d84174ca7a4e60db4d75912903e9679b643 (diff)
uitest: guard load_file
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: Ia924293dc2a12230fd13f69fd734875ced86be8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117593 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'sc/qa/uitest/calc_tests4/tdf138089.py')
-rw-r--r--sc/qa/uitest/calc_tests4/tdf138089.py60
1 files changed, 29 insertions, 31 deletions
diff --git a/sc/qa/uitest/calc_tests4/tdf138089.py b/sc/qa/uitest/calc_tests4/tdf138089.py
index 54e3015b3175..c59838df86db 100644
--- a/sc/qa/uitest/calc_tests4/tdf138089.py
+++ b/sc/qa/uitest/calc_tests4/tdf138089.py
@@ -13,36 +13,34 @@ class tdf138089(UITestCase):
def test_tdf138089(self):
- calc_doc = self.ui_test.load_file(get_url_for_data_file("tdf138089.xlsx"))
- xCalcDoc = self.xUITest.getTopFocusWindow()
- gridwin = xCalcDoc.getChild("grid_window")
- gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A1"}))
-
- self.assertFalse(is_row_hidden(calc_doc, 0))
- self.assertTrue(is_row_hidden(calc_doc, 1))
- self.assertTrue(is_row_hidden(calc_doc, 2))
- self.assertTrue(is_row_hidden(calc_doc, 3))
- self.assertFalse(is_row_hidden(calc_doc, 4))
- self.assertFalse(is_row_hidden(calc_doc, 5))
- self.assertFalse(is_row_hidden(calc_doc, 6))
-
- # Without the fix in place, this test would have crashed here
- self.ui_test.execute_modeless_dialog_through_command(".uno:DataFilterStandardFilter")
- xDialog = self.xUITest.getTopFocusWindow()
- self.assertEqual("2017-12-01", get_state_as_dict(xDialog.getChild("val1"))['Text'])
- self.assertEqual("过帐日期", get_state_as_dict(xDialog.getChild("field1"))["DisplayText"])
-
- xOKBtn = xDialog.getChild("ok")
- self.ui_test.close_dialog_through_button(xOKBtn)
-
- self.assertFalse(is_row_hidden(calc_doc, 0))
- self.assertTrue(is_row_hidden(calc_doc, 1))
- self.assertTrue(is_row_hidden(calc_doc, 2))
- self.assertTrue(is_row_hidden(calc_doc, 3))
- self.assertFalse(is_row_hidden(calc_doc, 4))
- self.assertFalse(is_row_hidden(calc_doc, 5))
- self.assertTrue(is_row_hidden(calc_doc, 6))
-
- self.ui_test.close_doc()
+ with self.ui_test.load_file(get_url_for_data_file("tdf138089.xlsx")) as calc_doc:
+ xCalcDoc = self.xUITest.getTopFocusWindow()
+ gridwin = xCalcDoc.getChild("grid_window")
+ gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A1"}))
+
+ self.assertFalse(is_row_hidden(calc_doc, 0))
+ self.assertTrue(is_row_hidden(calc_doc, 1))
+ self.assertTrue(is_row_hidden(calc_doc, 2))
+ self.assertTrue(is_row_hidden(calc_doc, 3))
+ self.assertFalse(is_row_hidden(calc_doc, 4))
+ self.assertFalse(is_row_hidden(calc_doc, 5))
+ self.assertFalse(is_row_hidden(calc_doc, 6))
+
+ # Without the fix in place, this test would have crashed here
+ self.ui_test.execute_modeless_dialog_through_command(".uno:DataFilterStandardFilter")
+ xDialog = self.xUITest.getTopFocusWindow()
+ self.assertEqual("2017-12-01", get_state_as_dict(xDialog.getChild("val1"))['Text'])
+ self.assertEqual("过帐日期", get_state_as_dict(xDialog.getChild("field1"))["DisplayText"])
+
+ xOKBtn = xDialog.getChild("ok")
+ self.ui_test.close_dialog_through_button(xOKBtn)
+
+ self.assertFalse(is_row_hidden(calc_doc, 0))
+ self.assertTrue(is_row_hidden(calc_doc, 1))
+ self.assertTrue(is_row_hidden(calc_doc, 2))
+ self.assertTrue(is_row_hidden(calc_doc, 3))
+ self.assertFalse(is_row_hidden(calc_doc, 4))
+ self.assertFalse(is_row_hidden(calc_doc, 5))
+ self.assertTrue(is_row_hidden(calc_doc, 6))
# vim: set shiftwidth=4 softtabstop=4 expandtab: