diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2021-12-13 11:29:56 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2021-12-13 13:28:48 +0100 |
commit | 72b25619960cdaa829c8ea10e27d9c0b20a2c26f (patch) | |
tree | 7a1af8a210adfa7af1addf8d421383f4f852e655 /sc/qa/unit/functions_array.cxx | |
parent | beddd069ca6f99536a5e2527a726ac42c7abe40e (diff) |
For now, disable tests giving dubious results on AArch64
when built with -ffp-contract enabled (-ffp-contract=on default on Clang 14
trunk since
<https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918>
"Making the code compliant to the documentation about Floating Point", cf.
19559ebbee160d1625d06feec7e6566772dad231 "Allow for a presumably more precise
result of BESSELY(80,9)"; and -ffp-contract=fast default when building with
optimizations on GCC) on both Linux (with
6cb20e0b298f41fe88984aebfe5454f936a0ae3a "Disable
CppunitTset_sc_*_functions_test for linux_aarch64 for now, too" reverted) and
macOS.
Change-Id: Ie867d999173410ec9868bd14c0ee04bbba371920
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126727
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'sc/qa/unit/functions_array.cxx')
-rw-r--r-- | sc/qa/unit/functions_array.cxx | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/sc/qa/unit/functions_array.cxx b/sc/qa/unit/functions_array.cxx index 00a17de34fd6..88a4b70d7c29 100644 --- a/sc/qa/unit/functions_array.cxx +++ b/sc/qa/unit/functions_array.cxx @@ -6,9 +6,11 @@ public: ArrayFunctionsTest(); void testArrayFormulasFODS(); + void testDubiousArrayFormulasFODS(); CPPUNIT_TEST_SUITE(ArrayFunctionsTest); CPPUNIT_TEST(testArrayFormulasFODS); + CPPUNIT_TEST(testDubiousArrayFormulasFODS); CPPUNIT_TEST_SUITE_END(); }; @@ -21,6 +23,20 @@ void ArrayFunctionsTest::testArrayFormulasFODS() FODS_FORMAT_TYPE, SotClipboardFormatId::NONE, 0, false); } +void ArrayFunctionsTest::testDubiousArrayFormulasFODS() +{ + //TODO: sc/qa/unit/data/functions/array/dubious/fods/linest.fods produces widely different + // values when built with -ffp-contract enabled (-ffp-contract=on default on Clang 14, + // -ffp-contract=fast default when building with optimizations on GCC) on at least aarch64: +#if !((defined __clang__ || defined __GNUC__) && defined __aarch64__) + OUString aDirectoryURL + = m_directories.getURLFromSrc(u"/sc/qa/unit/data/functions/array/dubious/fods/"); + recursiveScan(test::pass, "OpenDocument Spreadsheet Flat XML", aDirectoryURL, + "com.sun.star.comp.filter.OdfFlatXml,,com.sun.star.comp.Calc.XMLOasisImporter,com.sun.star.comp.Calc.XMLOasisExporter,,,true", + FODS_FORMAT_TYPE, SotClipboardFormatId::NONE, 0, false); +#endif +} + ArrayFunctionsTest::ArrayFunctionsTest(): FunctionsTest("sc/qa/unit/data/functions/array/fods/") { |