summaryrefslogtreecommitdiff
path: root/sc/qa/unit/helper
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2016-07-19 10:49:48 +0200
committerStephan Bergmann <sbergman@redhat.com>2016-07-19 10:49:48 +0200
commit58806ee799072776e04d49d95dcba525575f9ce7 (patch)
tree8ba475a62b15c4c8415c896151a60ffc5482d25e /sc/qa/unit/helper
parenta293ff34143f90c6836591fc1f4aa419342c5e1b (diff)
clang-tidy performance-unnecessary-value-param in sc
Change-Id: I1941c050a385e3a1020c5d2495471f5805c4c180
Diffstat (limited to 'sc/qa/unit/helper')
-rw-r--r--sc/qa/unit/helper/qahelper.cxx2
-rw-r--r--sc/qa/unit/helper/qahelper.hxx2
-rw-r--r--sc/qa/unit/helper/xpath.cxx2
-rw-r--r--sc/qa/unit/helper/xpath.hxx2
4 files changed, 4 insertions, 4 deletions
diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index ac61dc2f9955..e3493a18652a 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -747,7 +747,7 @@ std::string to_std_string(const OUString& rStr)
}
-void checkFormula(ScDocument& rDoc, const ScAddress& rPos, const char* expected, const char* msg, CppUnit::SourceLine sourceLine)
+void checkFormula(ScDocument& rDoc, const ScAddress& rPos, const char* expected, const char* msg, CppUnit::SourceLine const & sourceLine)
{
ScTokenArray* pCode = getTokens(rDoc, rPos);
if (!pCode)
diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx
index 9929c6c800c1..dc4afd19bf53 100644
--- a/sc/qa/unit/helper/qahelper.hxx
+++ b/sc/qa/unit/helper/qahelper.hxx
@@ -249,7 +249,7 @@ public:
CPPUNIT_ASSERT_EQUAL( static_cast<type>(expected), static_cast<type>(result) );
SCQAHELPER_DLLPUBLIC void checkFormula(ScDocument& rDoc, const ScAddress& rPos,
- const char* expected, const char* msg, CppUnit::SourceLine sourceLine);
+ const char* expected, const char* msg, CppUnit::SourceLine const & sourceLine);
#define ASSERT_FORMULA_EQUAL(doc, pos, expected, msg) \
checkFormula(doc, pos, expected, msg, CPPUNIT_SOURCELINE())
diff --git a/sc/qa/unit/helper/xpath.cxx b/sc/qa/unit/helper/xpath.cxx
index 2117b749b326..2d047b60bf61 100644
--- a/sc/qa/unit/helper/xpath.cxx
+++ b/sc/qa/unit/helper/xpath.cxx
@@ -25,7 +25,7 @@ xmlDocPtr XPathHelper::parseExport(ScDocShell& rShell, uno::Reference<lang::XMul
return parseExport(pTempFile, xSFactory, rFile);
}
-xmlDocPtr XPathHelper::parseExport(std::shared_ptr<utl::TempFile> pTempFile, uno::Reference<lang::XMultiServiceFactory> const & xSFactory, const OUString& rFile)
+xmlDocPtr XPathHelper::parseExport(std::shared_ptr<utl::TempFile> const & pTempFile, uno::Reference<lang::XMultiServiceFactory> const & xSFactory, const OUString& rFile)
{
// Read the XML stream we're interested in.
uno::Reference<packages::zip::XZipFileAccess2> xNameAccess = packages::zip::ZipFileAccess::createWithURL(comphelper::getComponentContext(xSFactory), pTempFile->GetURL());
diff --git a/sc/qa/unit/helper/xpath.hxx b/sc/qa/unit/helper/xpath.hxx
index 91a81e1253c3..86d1d279576e 100644
--- a/sc/qa/unit/helper/xpath.hxx
+++ b/sc/qa/unit/helper/xpath.hxx
@@ -53,7 +53,7 @@ namespace XPathHelper
* Should be used when the same exported file is used for testing different files in
* the same zip file.
*/
- SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(std::shared_ptr<utl::TempFile> pTempFile, uno::Reference< lang::XMultiServiceFactory> const & xSFactory,
+ SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(std::shared_ptr<utl::TempFile> const & pTempFile, uno::Reference< lang::XMultiServiceFactory> const & xSFactory,
const OUString& rFile);
}