diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-12-12 15:01:02 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-12-12 17:49:02 +0100 |
commit | 40b0bd21e87480b659e7ed92854eee385a2a3c55 (patch) | |
tree | e71ba92b77eead12445c68c866d7ba71f74e19f5 /sc/qa | |
parent | 4781ba436f72b5b763833c3c036e7f1c0e4d9e3b (diff) |
sc: rowcol: tdf#50916 pass ScDocument to the token classes
needed to create a fake ScDocument for the external ref manager, since
it has no ScDocument at all
Change-Id: Ia786ac291133e3c438694e81ecfb2590729a853d
Reviewed-on: https://gerrit.libreoffice.org/85050
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/qa')
-rw-r--r-- | sc/qa/unit/subsequent_export-test.cxx | 2 | ||||
-rw-r--r-- | sc/qa/unit/ucalc_formula.cxx | 34 |
2 files changed, 18 insertions, 18 deletions
diff --git a/sc/qa/unit/subsequent_export-test.cxx b/sc/qa/unit/subsequent_export-test.cxx index d5607629dc70..1b85a34ce8c0 100644 --- a/sc/qa/unit/subsequent_export-test.cxx +++ b/sc/qa/unit/subsequent_export-test.cxx @@ -2792,7 +2792,7 @@ void ScExportTest::testSharedFormulaExportXLS() return false; } - OUString aFormula = pFC->GetCode()->CreateString(&rDoc, aCxt, aPos); + OUString aFormula = pFC->GetCode()->CreateString(aCxt, aPos); aExpected = "Coefficients!RC[-1]"; if (aFormula != aExpected) { diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index a8a98ce2fa44..b90db089d8ed 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -3690,7 +3690,7 @@ void Test::testFormulaRefUpdateNameDeleteRow() sc::TokenStringContext aCxt(m_pDoc, formula::FormulaGrammar::GRAM_ENGLISH); const ScTokenArray* pCode = pName->GetCode(); - OUString aExpr = pCode->CreateString(m_pDoc, aCxt, ScAddress(0,0,0)); + OUString aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$4"), aExpr); // Insert a new name 'MyAddress' to reference $B$3. Note absolute row. @@ -3702,7 +3702,7 @@ void Test::testFormulaRefUpdateNameDeleteRow() sc::TokenStringContext aCxt2(m_pDoc, formula::FormulaGrammar::GRAM_ENGLISH); const ScTokenArray* pCode2 = pName2->GetCode(); - OUString aExpr2 = pCode2->CreateString(m_pDoc, aCxt2, ScAddress(0,0,0)); + OUString aExpr2 = pCode2->CreateString(aCxt2, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$3"), aExpr2); ScDocFunc& rFunc = getDocShell().GetDocFunc(); @@ -3713,16 +3713,16 @@ void Test::testFormulaRefUpdateNameDeleteRow() rFunc.DeleteCells(ScRange(0,2,0,m_pDoc->MaxCol(),2,0), &aMark, DelCellCmd::CellsUp, true); // The reference in the 'MyRange' name should get updated to B2:B3. - aExpr = pCode->CreateString(m_pDoc, aCxt, ScAddress(0,0,0)); + aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$3"), aExpr); // The reference in the 'MyAddress' name should get updated to $B$#REF!. - aExpr2 = pCode2->CreateString(m_pDoc, aCxt2, ScAddress(0,0,0)); + aExpr2 = pCode2->CreateString(aCxt2, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$#REF!"), aExpr2); // Delete row 3 again. rFunc.DeleteCells(ScRange(0,2,0,m_pDoc->MaxCol(),2,0), &aMark, DelCellCmd::CellsUp, true); - aExpr = pCode->CreateString(m_pDoc, aCxt, ScAddress(0,0,0)); + aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$2"), aExpr); // Undo and check. @@ -3735,7 +3735,7 @@ void Test::testFormulaRefUpdateNameDeleteRow() CPPUNIT_ASSERT(pName); pCode = pName->GetCode(); - aExpr = pCode->CreateString(m_pDoc, aCxt, ScAddress(0,0,0)); + aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$3"), aExpr); // Undo again and check. @@ -3745,13 +3745,13 @@ void Test::testFormulaRefUpdateNameDeleteRow() CPPUNIT_ASSERT(pName); pCode = pName->GetCode(); - aExpr = pCode->CreateString(m_pDoc, aCxt, ScAddress(0,0,0)); + aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$4"), aExpr); // Delete row 2-3. rFunc.DeleteCells(ScRange(0,1,0,m_pDoc->MaxCol(),2,0), &aMark, DelCellCmd::CellsUp, true); - aExpr = pCode->CreateString(m_pDoc, aCxt, ScAddress(0,0,0)); + aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$2"), aExpr); // Undo and check. @@ -3761,14 +3761,14 @@ void Test::testFormulaRefUpdateNameDeleteRow() CPPUNIT_ASSERT(pName); pCode = pName->GetCode(); - aExpr = pCode->CreateString(m_pDoc, aCxt, ScAddress(0,0,0)); + aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$4"), aExpr); pName2 = m_pDoc->GetRangeName()->findByUpperName("MYADDRESS"); CPPUNIT_ASSERT(pName2); pCode2 = pName2->GetCode(); - aExpr2 = pCode2->CreateString(m_pDoc, aCxt2, ScAddress(0,0,0)); + aExpr2 = pCode2->CreateString(aCxt2, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$3"), aExpr2); m_pDoc->InsertTab(1, "test2"); @@ -3781,7 +3781,7 @@ void Test::testFormulaRefUpdateNameDeleteRow() CPPUNIT_ASSERT(pName); pCode = pName->GetCode(); - aExpr = pCode->CreateString(m_pDoc, aCxt, ScAddress(0,0,0)); + aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$4"), aExpr); pName2 = m_pDoc->GetRangeName()->findByUpperName("MYADDRESS"); @@ -3794,7 +3794,7 @@ void Test::testFormulaRefUpdateNameDeleteRow() // relative to its base position on sheet 0 (same for the 'MyRange' range, // which is the reason why it is not updated either). // This is a tad confusing... - aExpr2 = pCode2->CreateString(m_pDoc, aCxt2, ScAddress(0,0,0)); + aExpr2 = pCode2->CreateString(aCxt2, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$3"), aExpr2); m_pDoc->DeleteTab(1); @@ -4022,7 +4022,7 @@ void Test::testFormulaRefUpdateNameDelete() m_pDoc->DeleteCol(1, 0, 3, 0, 0, 1); const ScTokenArray* pCode = pName->GetCode(); sc::TokenStringContext aCxt(m_pDoc, formula::FormulaGrammar::GRAM_ENGLISH); - OUString aExpr = pCode->CreateString(m_pDoc, aCxt, ScAddress(0,0,0)); + OUString aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$Test.$B$1"), aExpr); m_pDoc->DeleteTab(0); @@ -4181,7 +4181,7 @@ void Test::testTokenArrayRefUpdateMove() ScCompiler aComp(m_pDoc, aPos, m_pDoc->GetGrammar()); std::unique_ptr<ScTokenArray> pArray(aComp.CompileString(aTest)); - OUString aStr = pArray->CreateString(m_pDoc, aCxt, aPos); + OUString aStr = pArray->CreateString(aCxt, aPos); CPPUNIT_ASSERT_EQUAL(aTest, aStr); @@ -4189,7 +4189,7 @@ void Test::testTokenArrayRefUpdateMove() // string should not change. pArray->AdjustReferenceOnMove(aRefCxt, aPos, aPos); - aStr = pArray->CreateString(m_pDoc, aCxt, aPos); + aStr = pArray->CreateString(aCxt, aPos); CPPUNIT_ASSERT_EQUAL(aTest, aStr); } @@ -8463,7 +8463,7 @@ void Test::testRefR1C1WholeCol() ScCompiler aComp(m_pDoc, aPos, FormulaGrammar::GRAM_ENGLISH_XL_R1C1); std::unique_ptr<ScTokenArray> pTokens(aComp.CompileString("=C[10]")); sc::TokenStringContext aCxt(m_pDoc, formula::FormulaGrammar::GRAM_ENGLISH); - OUString aFormula = pTokens->CreateString(m_pDoc, aCxt, aPos); + OUString aFormula = pTokens->CreateString(aCxt, aPos); CPPUNIT_ASSERT_EQUAL(OUString("L:L"), aFormula); @@ -8478,7 +8478,7 @@ void Test::testRefR1C1WholeRow() ScCompiler aComp(m_pDoc, aPos, FormulaGrammar::GRAM_ENGLISH_XL_R1C1); std::unique_ptr<ScTokenArray> pTokens(aComp.CompileString("=R[3]")); sc::TokenStringContext aCxt(m_pDoc, formula::FormulaGrammar::GRAM_ENGLISH); - OUString aFormula = pTokens->CreateString(m_pDoc, aCxt, aPos); + OUString aFormula = pTokens->CreateString(aCxt, aPos); CPPUNIT_ASSERT_EQUAL(OUString("5:5"), aFormula); |