diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-06 08:33:06 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-06 13:00:56 +0200 |
commit | 4f7b2ca221efe9f198994c98ac4603c9e4688f11 (patch) | |
tree | e97f4e99d774af4ddfde25e311d07eb9710a57fa /sc/qa | |
parent | 330a022e8bcd413d0bdc0b45916503ddfee5d0cc (diff) |
loplugin:unusedfields in sc
found a couple more by running
make build-nocheck
to exclude testing code
Also, teach unusedfields loplugin about operator<<, since
referring to a field in an ostream operator<< does not indicate a
real use, it's normally for debugging
Change-Id: I3dce22bf5afda2fd09e01de9bf1d0ef85e535aa8
Reviewed-on: https://gerrit.libreoffice.org/39625
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/qa')
-rw-r--r-- | sc/qa/unit/ucalc_column.cxx | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/sc/qa/unit/ucalc_column.cxx b/sc/qa/unit/ucalc_column.cxx index 8aeb6f2dbf57..4a64f695a414 100644 --- a/sc/qa/unit/ucalc_column.cxx +++ b/sc/qa/unit/ucalc_column.cxx @@ -140,7 +140,6 @@ void Test::testMultipleDataCellsInRange() CPPUNIT_ASSERT_EQUAL(sc::MultiDataCellState::HasOneCell, aState.meState); CPPUNIT_ASSERT_EQUAL(SCCOL(1), aState.mnCol1); CPPUNIT_ASSERT_EQUAL(SCROW(2), aState.mnRow1); - CPPUNIT_ASSERT_EQUAL(SCTAB(0), aState.mnTab1); // Set another numeric value to B4. m_pDoc->SetValue(ScAddress(1,3,0), 2.0); @@ -149,7 +148,6 @@ void Test::testMultipleDataCellsInRange() CPPUNIT_ASSERT_EQUAL(sc::MultiDataCellState::HasMultipleCells, aState.meState); CPPUNIT_ASSERT_EQUAL(SCCOL(1), aState.mnCol1); CPPUNIT_ASSERT_EQUAL(SCROW(2), aState.mnRow1); - CPPUNIT_ASSERT_EQUAL(SCTAB(0), aState.mnTab1); // Set the query range to B4:B5. Now it should only report one cell, with // B4 being the first non-empty cell. @@ -159,7 +157,6 @@ void Test::testMultipleDataCellsInRange() CPPUNIT_ASSERT_EQUAL(sc::MultiDataCellState::HasOneCell, aState.meState); CPPUNIT_ASSERT_EQUAL(SCCOL(1), aState.mnCol1); CPPUNIT_ASSERT_EQUAL(SCROW(3), aState.mnRow1); - CPPUNIT_ASSERT_EQUAL(SCTAB(0), aState.mnTab1); // Set the query range to A1:C3. The first non-empty cell should be B3. aRange = ScRange(0,0,0,2,2,0); @@ -167,7 +164,6 @@ void Test::testMultipleDataCellsInRange() CPPUNIT_ASSERT_EQUAL(sc::MultiDataCellState::HasOneCell, aState.meState); CPPUNIT_ASSERT_EQUAL(SCCOL(1), aState.mnCol1); CPPUNIT_ASSERT_EQUAL(SCROW(2), aState.mnRow1); - CPPUNIT_ASSERT_EQUAL(SCTAB(0), aState.mnTab1); // Set string cells to D4 and F5, and query D3:F5. D4 should be the first // non-empty cell. @@ -178,7 +174,6 @@ void Test::testMultipleDataCellsInRange() CPPUNIT_ASSERT_EQUAL(sc::MultiDataCellState::HasMultipleCells, aState.meState); CPPUNIT_ASSERT_EQUAL(SCCOL(3), aState.mnCol1); CPPUNIT_ASSERT_EQUAL(SCROW(3), aState.mnRow1); - CPPUNIT_ASSERT_EQUAL(SCTAB(0), aState.mnTab1); // TODO : add more test cases as needed. |