summaryrefslogtreecommitdiff
path: root/sc/qa
diff options
context:
space:
mode:
authorLuboš Luňák <l.lunak@collabora.com>2022-03-15 20:03:50 +0100
committerLuboš Luňák <l.lunak@collabora.com>2022-04-14 10:17:02 +0200
commit6338a0a44d3c9eeac26419aecb866682a41eed52 (patch)
tree1cac2d6cbb4407e2b35a15bc46cdcf29bda8f632 /sc/qa
parente6abff6c96f5b429f8da5ff0db173cbda558c69b (diff)
fix comparison operators in Excel export, #2
It turns out that the end-vs-start comparison was intentional and the file causing problems is broken, so more or less revert 83d599fd7c530d14f70ac60bd673b66640191bf7, and I'll handle the problematic file in another commit. Change-Id: I5c7538a7c3eeea9c5fd1661e1a9a2c3370b799c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131636 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'sc/qa')
-rw-r--r--sc/qa/unit/data/xlsx/tdf58243.xlsxbin0 -> 17952 bytes
-rw-r--r--sc/qa/unit/subsequent_export_test2.cxx11
2 files changed, 11 insertions, 0 deletions
diff --git a/sc/qa/unit/data/xlsx/tdf58243.xlsx b/sc/qa/unit/data/xlsx/tdf58243.xlsx
new file mode 100644
index 000000000000..f95e13b4b6db
--- /dev/null
+++ b/sc/qa/unit/data/xlsx/tdf58243.xlsx
Binary files differ
diff --git a/sc/qa/unit/subsequent_export_test2.cxx b/sc/qa/unit/subsequent_export_test2.cxx
index ad3f125db7d9..9776b1629197 100644
--- a/sc/qa/unit/subsequent_export_test2.cxx
+++ b/sc/qa/unit/subsequent_export_test2.cxx
@@ -217,6 +217,7 @@ public:
void testTdf145059();
void testTdf130104_XLSXIndent();
void testWholeRowBold();
+ void testXlsxRowsOrder();
CPPUNIT_TEST_SUITE(ScExportTest2);
@@ -333,6 +334,7 @@ public:
CPPUNIT_TEST(testTdf145059);
CPPUNIT_TEST(testTdf130104_XLSXIndent);
CPPUNIT_TEST(testWholeRowBold);
+ CPPUNIT_TEST(testXlsxRowsOrder);
CPPUNIT_TEST_SUITE_END();
@@ -3113,6 +3115,15 @@ void ScExportTest2::testWholeRowBold()
xDocSh3->DoClose();
}
+void ScExportTest2::testXlsxRowsOrder()
+{
+ ScDocShellRef xDocSh = loadDoc(u"tdf58243.", FORMAT_XLSX);
+ CPPUNIT_ASSERT(xDocSh.is());
+ // Make sure code in SheetDataBuffer doesn't assert columns/rows sorting.
+ ScBootstrapFixture::exportTo(*xDocSh, FORMAT_XLSX);
+ xDocSh->DoClose();
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest2);
CPPUNIT_PLUGIN_IMPLEMENT();