diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-02-02 12:41:42 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-02-03 16:04:17 +0100 |
| commit | e3308af401013713bbfe27b6df9952586c52f4aa (patch) | |
| tree | d498f4a3bfefef5a4c964986cf76d86201ba58e8 /sc/qa | |
| parent | a4fbb496ef001d62fce0ad3cdd7a829f99aa182e (diff) | |
TypedWhichId in sc
Change-Id: I43558191f65bfb07abfbc92970629d5dd561a04e
Reviewed-on: https://gerrit.libreoffice.org/49141
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/qa')
| -rw-r--r-- | sc/qa/unit/subsequent_filters-test.cxx | 6 | ||||
| -rw-r--r-- | sc/qa/unit/ucalc.cxx | 4 |
2 files changed, 4 insertions, 6 deletions
diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx index f23786355671..24b93c5e6a8f 100644 --- a/sc/qa/unit/subsequent_filters-test.cxx +++ b/sc/qa/unit/subsequent_filters-test.cxx @@ -1270,7 +1270,7 @@ void checkCellValidity( const ScAddress& rValBaseAddr, const ScRange& rRange, co SCROW nBRow( rValBaseAddr.Row() ); SCTAB nTab( static_cast<sal_Int32>(rValBaseAddr.Tab()) ); //get from the document the data validation entry we are checking against - const SfxUInt32Item* pItem = static_cast<const SfxUInt32Item*>(rDoc.GetAttr(nBCol, nBRow, nTab, ATTR_VALIDDATA) ); + const SfxUInt32Item* pItem = rDoc.GetAttr(nBCol, nBRow, nTab, ATTR_VALIDDATA); const ScValidationData* pValData = rDoc.GetValidationEntry( pItem->GetValue() ); CPPUNIT_ASSERT(pValData); @@ -1279,7 +1279,7 @@ void checkCellValidity( const ScAddress& rValBaseAddr, const ScRange& rRange, co { for(SCROW j = rRange.aStart.Row(); j <= rRange.aEnd.Row(); ++j) { - const SfxUInt32Item* pItemTest = static_cast<const SfxUInt32Item*>( rDoc.GetAttr(i, j, nTab, ATTR_VALIDDATA) ); + const SfxUInt32Item* pItemTest = rDoc.GetAttr(i, j, nTab, ATTR_VALIDDATA); const ScValidationData* pValDataTest = rDoc.GetValidationEntry( pItemTest->GetValue() ); //prevent string operations for occurring unnecessarily if(!(pValDataTest && pValData->GetKey() == pValDataTest->GetKey())) @@ -3402,7 +3402,7 @@ namespace { void checkValidationFormula(const ScAddress& rPos, const ScDocument& rDoc, const OUString& rExpectedFormula) { - const SfxUInt32Item* pItem = static_cast<const SfxUInt32Item*>(rDoc.GetAttr(rPos, ATTR_VALIDDATA) ); + const SfxUInt32Item* pItem = rDoc.GetAttr(rPos, ATTR_VALIDDATA); CPPUNIT_ASSERT(pItem); sal_uLong nKey = pItem->GetValue(); const ScValidationData* pData = rDoc.GetValidationEntry(nKey); diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 7c47940cc7bd..7651a65a448f 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -3611,9 +3611,7 @@ void Test::testCopyPasteSkipEmpty() return false; } - const SvxBrushItem* pBrush = - dynamic_cast<const SvxBrushItem*>(mpDoc->GetAttr(aPos, ATTR_BACKGROUND)); - + const SvxBrushItem* pBrush = mpDoc->GetAttr(aPos, ATTR_BACKGROUND); if (!pBrush) { cerr << aPosStr << ": failed to get brush item from the cell." << endl; |