diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-22 13:19:27 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-23 08:05:21 +0100 |
| commit | f90139cceeee60116c28140f1bfb1d88076d1591 (patch) | |
| tree | 19ac79f953de976d25ce3b9badf74ffeaa29c57c /sc/sdi/docsh.sdi | |
| parent | 2a1fb4401da16f6a18c0bd05fe4b460a3048f9b5 (diff) | |
Revert "unused SID commands in sc"
This reverts commit 9c4350441191ccfd6af3d73e13b4eb59af7ed6d1.
Eike Rathke:
Odd, I don't even remember what these slots were used for..
Ugh.. now I think I know.. (very) old recorded Basic macros used slot:number with the dispatcher instead of the .uno:... commands, so removing/renumbering slots may actually break those.
I'm not sure if we already deprecated the slot number thing in an earlier release or maybe it was already done back in OOo times, I simply don't remember. Must be at least 1.5 decades since slot numbers were replaced with .uno commands, but old recorded macros are still supported.
However, our qaDevOOo tests and some other tests (in Java) still use slot:#### notation, git grep 'slot:[0-9]'
I think best is to revert this change and abandon the other SID removals.
Change-Id: I091cf71dd38772dac7491afd6f28951b54510eaf
Reviewed-on: https://gerrit.libreoffice.org/46963
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/sdi/docsh.sdi')
| -rw-r--r-- | sc/sdi/docsh.sdi | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sc/sdi/docsh.sdi b/sc/sdi/docsh.sdi index 612d09e54006..fdb22acf3e0c 100644 --- a/sc/sdi/docsh.sdi +++ b/sc/sdi/docsh.sdi @@ -40,6 +40,8 @@ interface TableSelection FID_TAB_RTL [ ExecMethod = ExecuteTable; StateMethod = GetStateTable; ] FID_TAB_SET_TAB_BG_COLOR [ ExecMethod = ExecuteTable; StateMethod = GetStateTable; ] FID_TAB_TOGGLE_GRID [ ExecMethod = ExecuteTable; StateMethod = GetStateTable; ] + + SID_TABLE_ACTIVATE [ ExecMethod = Execute; ] } @@ -48,6 +50,7 @@ interface TableDocument { SID_OPEN_CALC [ ExecMethod = Execute; StateMethod = GetState; ] SID_SBA_IMPORT [ ExecMethod = Execute; StateMethod = GetState; ] + SID_SC_SETTEXT [ ExecMethod = Execute; StateMethod = GetState; ] SID_TABLES_COUNT [ StateMethod = GetState; ] SID_ATTR_YEAR2000 [ StateMethod = GetState; ExecMethod = Execute; ] SID_CHART_SOURCE [ ExecMethod = Execute; ] @@ -57,6 +60,7 @@ interface TableDocument FID_HARD_RECALC [ ExecMethod = Execute; StateMethod = GetState; ] SID_UPDATETABLINKS [ ExecMethod = Execute; ] SID_REIMPORT_AFTER_LOAD [ ExecMethod = Execute; ] + SID_AUTO_STYLE [ ExecMethod = Execute; ] SID_GET_COLORLIST [ ExecMethod = Execute; ] |