diff options
| author | Ravindra_Vidhate <ravindra.vidhate@synerzip.com> | 2015-05-12 14:17:06 +0530 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2015-05-12 10:12:06 +0000 |
| commit | d2ef03ce0b9295034f9078bc04acbf4cfc939ef6 (patch) | |
| tree | ef3eedc44f927648a4eef7c30cb30196eff54be8 /sc/sdi | |
| parent | 2b5915da481990fd6ea272104215d82b6fbf5dbb (diff) | |
tdf#84153: "Edit Comment" in context menu when a cell has a comment
Problem Description :
1. When a cell doesn't has comment, the contextual menu shows menu
item "Insert Comment".
2. Also when the cell has the comment, the contextual menu shows
following menu items
"Insert Comment"
"Delete Comment"
"Show Comment"
In the second case mentioned above, the contextual menu should show
the menu item "Edit Comment" instead of "Insert Comment"
XML difference: None
After RT : None
Solution :
In this patch, a new menu item "Edit Comment" have been added. So at the
time of the display it checks whether cell has comment associated with it.
If comments are present for cell, it will display "Edit Comment" in the
contextual menu otherwise "Insert Comment" will be displayed.
TODO: Writing a UT seems to be tricky for this change.
Need to analyze and will raise the UT in separate CL.
Change-Id: Ie0499d02157c4fd18894c5f203c363f64659f3b3
Reviewed-on: https://gerrit.libreoffice.org/15713
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sc/sdi')
| -rw-r--r-- | sc/sdi/cellsh.sdi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sc/sdi/cellsh.sdi b/sc/sdi/cellsh.sdi index 7aca440dc26a..6da3c75b9829 100644 --- a/sc/sdi/cellsh.sdi +++ b/sc/sdi/cellsh.sdi @@ -192,6 +192,7 @@ interface CellSelection SID_CHARMAP [ ExecMethod = ExecuteEdit; StateMethod = GetCellState; ] SID_INSERT_POSTIT [ ExecMethod = ExecuteEdit; StateMethod = GetCellState; ] + SID_EDIT_POSTIT [ ExecMethod = ExecuteEdit; StateMethod = GetCellState; ] SID_COLLABORATION [ ExecMethod = Execute; ] SID_TABOP [ ExecMethod = ExecuteEdit; StateMethod = GetState; ] |