diff options
| author | Dennis Francis <dennis.francis@collabora.com> | 2020-07-15 15:55:45 +0530 |
|---|---|---|
| committer | Dennis Francis <dennis.francis@collabora.com> | 2020-07-24 15:21:31 +0200 |
| commit | 15856609795c57861dc950b93250fab953c3cb92 (patch) | |
| tree | f1e46eb2ccce4534328aefcba67f89a35011fe82 /sc/sdi | |
| parent | 1e96228637bd547636fb9084f938c1f822965c19 (diff) | |
lok-freezepanes: Generalize FreezePanes* uno-commands...
to allow an integer parameter as the row/column index of the freeze and
use them to set/get freeze indices (row/column) from the lok clients.
The behaviour of the exisiting freeze/split-panes controls in desktop
Calc is not affected, but new menu/notebookbar options can be added for
freezing on a specific row/column in a follow-up commit.
For now, the freeze-panes are shared between all views for each tab of
the spreadsheet. "Private" freeze-panes support can also be added
without much difficulty (for this we need another uno command for the
private/shared flag, but that can be in a separate commit).
Notes regarding compatibility:
Since Online-Calc has support only for the freeze-panes functionality
presently, any pre-exisiting 'real splits' in the spreadsheet (created
using the native-desktop Calc or alternatives) are converted to
equivalent 'freezes' on import, but on export, such 'freezes' are
re-converted and written as 'real splits'. In case the spreadsheet has
'freezes' on import, they are used/exported as such. In short, the type
of sheet-window splits in the document is preserved.
Change-Id: Ia990616f5cedfb2b5db820770c17ec7e209f0e48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99352
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Diffstat (limited to 'sc/sdi')
| -rw-r--r-- | sc/sdi/scalc.sdi | 8 | ||||
| -rw-r--r-- | sc/sdi/tabvwsh.sdi | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/sc/sdi/scalc.sdi b/sc/sdi/scalc.sdi index b3b1d3258492..93a6b67be6e5 100644 --- a/sc/sdi/scalc.sdi +++ b/sc/sdi/scalc.sdi @@ -1911,8 +1911,8 @@ SfxVoidItem FreezePanes SID_WINDOW_FIX GroupId = SfxGroupId::View; ] -SfxVoidItem FreezePanesFirstColumn SID_WINDOW_FIX_COL -() +SfxInt32Item FreezePanesColumn SID_WINDOW_FIX_COL + [ AutoUpdate = FALSE, FastCall = FALSE, @@ -1928,8 +1928,8 @@ SfxVoidItem FreezePanesFirstColumn SID_WINDOW_FIX_COL GroupId = SfxGroupId::View; ] -SfxVoidItem FreezePanesFirstRow SID_WINDOW_FIX_ROW -() +SfxInt32Item FreezePanesRow SID_WINDOW_FIX_ROW + [ AutoUpdate = FALSE, FastCall = FALSE, diff --git a/sc/sdi/tabvwsh.sdi b/sc/sdi/tabvwsh.sdi index 965e8656d34d..d122321c856b 100644 --- a/sc/sdi/tabvwsh.sdi +++ b/sc/sdi/tabvwsh.sdi @@ -144,8 +144,8 @@ interface TableEditView SID_CURRENTDOC [ ExecMethod = Execute; StateMethod = GetState; ] SID_WINDOW_SPLIT [ ExecMethod = Execute; StateMethod = GetState; ] SID_WINDOW_FIX [ ExecMethod = Execute; StateMethod = GetState; ] - SID_WINDOW_FIX_ROW [ ExecMethod = Execute; ] - SID_WINDOW_FIX_COL [ ExecMethod = Execute; ] + SID_WINDOW_FIX_ROW [ ExecMethod = Execute; StateMethod = GetState; ] + SID_WINDOW_FIX_COL [ ExecMethod = Execute; StateMethod = GetState; ] SID_SAVEDOC [ ExecMethod = ExecuteSave ; |