diff options
| author | Maxim Monastirsky <momonasmon@gmail.com> | 2020-03-12 01:26:51 +0200 |
|---|---|---|
| committer | Heiko Tietze <heiko.tietze@documentfoundation.org> | 2020-03-12 08:34:45 +0100 |
| commit | 02cac3ee70760234db0fad44cb9095dfccc538a1 (patch) | |
| tree | f351eb6275482eba7c50280e13396b2ce5fab7ca /sc/sdi | |
| parent | 34f91740cde8e77bd429f468ce0d797d8b0c2af4 (diff) | |
tdf#95854 Same shortcut for insert and edit comment
But at the same time keep them as two separate commands for tdf#84153.
The idea is to define a global shortcut for the insert command (it's
the same shortcut in all modules anyway), and then override it as a
Calc-specific shortcut for the edit command. As a result, both menu
(or context menu) items will show the same shortcut, but what will be
actually executed by the shortcut is the edit command (as module
specific commands have higher priority). This would work, as both
commands share the same execution code. The only problem is that the
edit command is disabled when the cell doesn't have a comment, and so
can't be executed. Solve that by setting the FastCall sdi property on
it (and reuse this general solution for the lok case too).
Change-Id: I8a7280edb2aad7016ca31c63ca778b98fef85365
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90354
Tested-by: Jenkins
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Diffstat (limited to 'sc/sdi')
| -rw-r--r-- | sc/sdi/cellsh.sdi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/sdi/cellsh.sdi b/sc/sdi/cellsh.sdi index d5e936b06cf0..9382eea0134f 100644 --- a/sc/sdi/cellsh.sdi +++ b/sc/sdi/cellsh.sdi @@ -199,7 +199,7 @@ interface CellSelection SID_EDIT_POSTIT [ ExecMethod = ExecuteEdit; StateMethod = GetCellState; - ToolBoxConfig, MenuConfig , AccelConfig; + FastCall, ToolBoxConfig, MenuConfig, AccelConfig; ] SID_TABOP [ ExecMethod = ExecuteEdit; StateMethod = GetState; ] |