diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-04-11 11:46:10 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-04-12 10:10:46 +0200 |
| commit | 4b57c28302def4dd56b2dc8ffb73f21b688a6534 (patch) | |
| tree | 7e6ecddbcea60ec39e0525c4902783f6a97dd8ee /sc/source/core | |
| parent | 9e4d84daf279a63052cfd0aeebd2d67dfaf07c67 (diff) | |
tag ScAddress and friends with SAL_WARN_UNUSED
Change-Id: I4ed6b1e8b4225a87fbcb863a47c84e30228b5352
Reviewed-on: https://gerrit.libreoffice.org/36407
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/source/core')
| -rw-r--r-- | sc/source/core/data/column2.cxx | 10 | ||||
| -rw-r--r-- | sc/source/core/data/conditio.cxx | 1 | ||||
| -rw-r--r-- | sc/source/core/data/documen5.cxx | 1 | ||||
| -rw-r--r-- | sc/source/core/tool/address.cxx | 1 |
4 files changed, 3 insertions, 10 deletions
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx index 58206e30dda5..c73dbdbd73d6 100644 --- a/sc/source/core/data/column2.cxx +++ b/sc/source/core/data/column2.cxx @@ -2222,15 +2222,13 @@ class FillMatrixHandler size_t mnMatCol; size_t mnTopRow; - SCCOL mnCol; - SCTAB mnTab; ScDocument* mpDoc; svl::SharedStringPool& mrPool; svl::SharedStringPool* mpPool; // if matrix is not in the same document public: - FillMatrixHandler(ScMatrix& rMat, size_t nMatCol, size_t nTopRow, SCCOL nCol, SCTAB nTab, ScDocument* pDoc, svl::SharedStringPool* pPool) : - mrMat(rMat), mnMatCol(nMatCol), mnTopRow(nTopRow), mnCol(nCol), mnTab(nTab), + FillMatrixHandler(ScMatrix& rMat, size_t nMatCol, size_t nTopRow, ScDocument* pDoc, svl::SharedStringPool* pPool) : + mrMat(rMat), mnMatCol(nMatCol), mnTopRow(nTopRow), mpDoc(pDoc), mrPool(pDoc->GetSharedStringPool()), mpPool(pPool) {} void operator() (const sc::CellStoreType::value_type& node, size_t nOffset, size_t nDataSize) @@ -2320,8 +2318,6 @@ public: double fVal; if (rCell.GetErrorOrValue(nErr, fVal)) { - ScAddress aAdr(mnCol, nThisRow, mnTab); - if (nErr != FormulaError::NONE) fVal = CreateDoubleError(nErr); @@ -2370,7 +2366,7 @@ public: void ScColumn::FillMatrix( ScMatrix& rMat, size_t nMatCol, SCROW nRow1, SCROW nRow2, svl::SharedStringPool* pPool ) const { - FillMatrixHandler aFunc(rMat, nMatCol, nRow1, nCol, nTab, pDocument, pPool); + FillMatrixHandler aFunc(rMat, nMatCol, nRow1, pDocument, pPool); sc::ParseBlock(maCells.begin(), maCells, aFunc, nRow1, nRow2); } diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx index a2b2f1886b60..ea0762295e87 100644 --- a/sc/source/core/data/conditio.cxx +++ b/sc/source/core/data/conditio.cxx @@ -1375,7 +1375,6 @@ ScTokenArray* ScConditionEntry::CreateFlatCopiedTokenArray( sal_uInt16 nIndex ) { assert(nIndex <= 1); ScTokenArray* pRet = nullptr; - ScAddress aAddr; if ( nIndex==0 ) { diff --git a/sc/source/core/data/documen5.cxx b/sc/source/core/data/documen5.cxx index 09a4162da72c..31eaf827911f 100644 --- a/sc/source/core/data/documen5.cxx +++ b/sc/source/core/data/documen5.cxx @@ -123,7 +123,6 @@ void ScDocument::UpdateAllCharts() SdrPage* pPage = pDrawLayer->GetPage(static_cast<sal_uInt16>(nTab)); OSL_ENSURE(pPage,"Page ?"); - ScRange aRange; SdrObjListIter aIter( *pPage, SdrIterMode::DeepNoGroups ); SdrObject* pObject = aIter.Next(); while (pObject) diff --git a/sc/source/core/tool/address.cxx b/sc/source/core/tool/address.cxx index ad82b72a2218..72b1862f221d 100644 --- a/sc/source/core/tool/address.cxx +++ b/sc/source/core/tool/address.cxx @@ -1146,7 +1146,6 @@ static ScRefFlags lcl_ScAddress_Parse_OOo( const sal_Unicode* p, ScDocument* pDo OUString aTab; bool bExtDoc = false; bool bExtDocInherited = false; - const ScAddress aCurPos(rAddr); // Lets see if this is a reference to something in an external file. A // document name is always quoted and has a trailing #. |