diff options
author | Noel Grandin <noel@peralex.com> | 2016-09-29 12:43:17 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-09-30 06:57:26 +0000 |
commit | 4d87443bf59c3242d58b56cc1583d73213ae1f2f (patch) | |
tree | c1f74fc569506299100b5063f14c09e46035a943 /sc/source/core | |
parent | 8e812b87ff7f8c5bf2c6f8858646c55effd2eea3 (diff) |
loplugin:constantparam
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c
Reviewed-on: https://gerrit.libreoffice.org/29321
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/source/core')
-rw-r--r-- | sc/source/core/data/clipcontext.cxx | 9 | ||||
-rw-r--r-- | sc/source/core/data/column.cxx | 2 | ||||
-rw-r--r-- | sc/source/core/data/documen3.cxx | 2 | ||||
-rw-r--r-- | sc/source/core/data/document.cxx | 4 | ||||
-rw-r--r-- | sc/source/core/data/table3.cxx | 8 |
5 files changed, 10 insertions, 15 deletions
diff --git a/sc/source/core/data/clipcontext.cxx b/sc/source/core/data/clipcontext.cxx index 16084be70c6d..8b0ce0df315b 100644 --- a/sc/source/core/data/clipcontext.cxx +++ b/sc/source/core/data/clipcontext.cxx @@ -328,8 +328,8 @@ bool CopyFromClipContext::isDateCell( const ScColumn& rCol, SCROW nRow ) const } CopyToClipContext::CopyToClipContext( - ScDocument& rDoc, bool bKeepScenarioFlags, bool bCloneNotes) : - ClipContextBase(rDoc), mbKeepScenarioFlags(bKeepScenarioFlags), mbCloneNotes(bCloneNotes) {} + ScDocument& rDoc, bool bKeepScenarioFlags) : + ClipContextBase(rDoc), mbKeepScenarioFlags(bKeepScenarioFlags) {} CopyToClipContext::~CopyToClipContext() {} @@ -338,11 +338,6 @@ bool CopyToClipContext::isKeepScenarioFlags() const return mbKeepScenarioFlags; } -bool CopyToClipContext::isCloneNotes() const -{ - return mbCloneNotes; -} - CopyToDocContext::CopyToDocContext(ScDocument& rDoc) : ClipContextBase(rDoc), mbStartListening(true) {} diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index 95959b9386c4..ea92124982c5 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -1027,7 +1027,7 @@ void ScColumn::CopyToClip( rCxt.isKeepScenarioFlags() ? (ScMF::All & ~ScMF::Scenario) : ScMF::All ); { - CopyToClipHandler aFunc(*this, rColumn, rCxt.getBlockPosition(rColumn.nTab, rColumn.nCol), rCxt.isCloneNotes()); + CopyToClipHandler aFunc(*this, rColumn, rCxt.getBlockPosition(rColumn.nTab, rColumn.nCol), true/*CloneNotes*/); sc::ParseBlock(maCells.begin(), maCells, aFunc, nRow1, nRow2); } diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx index 5aa0fcf2e115..eab54acab123 100644 --- a/sc/source/core/data/documen3.cxx +++ b/sc/source/core/data/documen3.cxx @@ -1408,7 +1408,7 @@ void ScDocument::Reorder( const sc::ReorderParam& rParam ) bool bOldEnableIdle = IsIdleEnabled(); EnableIdle(false); - pTab->Reorder(rParam, nullptr); + pTab->Reorder(rParam); EnableIdle(bOldEnableIdle); } diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx index 9462a54e9bbf..415c3e647d51 100644 --- a/sc/source/core/data/document.cxx +++ b/sc/source/core/data/document.cxx @@ -2183,7 +2183,7 @@ void ScDocument::CopyToClip(const ScClipParam& rClipParam, pClipDoc->ResetClip(this, pMarks); - sc::CopyToClipContext aCxt(*pClipDoc, bKeepScenarioFlags, true/*bCloneNoteCaptions*/); + sc::CopyToClipContext aCxt(*pClipDoc, bKeepScenarioFlags); CopyRangeNamesToClip(pClipDoc, aClipRange, pMarks); for (SCTAB i = 0; i < nEndTab; ++i) @@ -2285,7 +2285,7 @@ void ScDocument::CopyTabToClip(SCCOL nCol1, SCROW nRow1, rClipParam.maRanges.Append(ScRange(nCol1, nRow1, 0, nCol2, nRow2, 0)); pClipDoc->ResetClip( this, nTab ); - sc::CopyToClipContext aCxt(*pClipDoc, false, true); + sc::CopyToClipContext aCxt(*pClipDoc, false); if (nTab < static_cast<SCTAB>(maTabs.size()) && nTab < static_cast<SCTAB>(pClipDoc->maTabs.size())) if (maTabs[nTab] && pClipDoc->maTabs[nTab]) maTabs[nTab]->CopyToClip(aCxt, nCol1, nRow1, nCol2, nRow2, pClipDoc->maTabs[nTab]); diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index 158686e9fbcf..8cec68efb1b3 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -1752,7 +1752,7 @@ void ScTable::Sort( DestroySortCollator(); } -void ScTable::Reorder( const sc::ReorderParam& rParam, ScProgress* pProgress ) +void ScTable::Reorder( const sc::ReorderParam& rParam ) { if (rParam.maOrderIndices.empty()) return; @@ -1767,10 +1767,10 @@ void ScTable::Reorder( const sc::ReorderParam& rParam, ScProgress* pProgress ) pArray->ReorderByRow(rParam.maOrderIndices); if (pArray->IsUpdateRefs()) SortReorderByRowRefUpdate( - pArray.get(), rParam.maSortRange.aStart.Col(), rParam.maSortRange.aEnd.Col(), pProgress); + pArray.get(), rParam.maSortRange.aStart.Col(), rParam.maSortRange.aEnd.Col(), nullptr); else SortReorderByRow( - pArray.get(), rParam.maSortRange.aStart.Col(), rParam.maSortRange.aEnd.Col(), pProgress); + pArray.get(), rParam.maSortRange.aStart.Col(), rParam.maSortRange.aEnd.Col(), nullptr); } else { @@ -1778,7 +1778,7 @@ void ScTable::Reorder( const sc::ReorderParam& rParam, ScProgress* pProgress ) pArray->SetOrderIndices(rParam.maOrderIndices); SortReorderByColumn( pArray.get(), rParam.maSortRange.aStart.Row(), rParam.maSortRange.aEnd.Row(), - rParam.mbPattern, pProgress); + rParam.mbPattern, nullptr); } } |