diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-03 15:43:04 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-03 20:47:58 +0100 |
| commit | 49747ff2337fd1f4a3ee8e16d6328b8dacad99ec (patch) | |
| tree | 110901102d4ae356b161434a4e4064a28a0a738a /sc/source/filter/excel/excform.cxx | |
| parent | 0981f1d8c8a8918b5f28bf5605023b07e73b0d44 (diff) | |
tdf#120703 PVS: V547 Expression is always true/false
Change-Id: I75082c85862b83ed2503900186ce9c70783e54db
Reviewed-on: https://gerrit.libreoffice.org/62817
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'sc/source/filter/excel/excform.cxx')
| -rw-r--r-- | sc/source/filter/excel/excform.cxx | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sc/source/filter/excel/excform.cxx b/sc/source/filter/excel/excform.cxx index de4f83c73121..ed4078f5fe25 100644 --- a/sc/source/filter/excel/excform.cxx +++ b/sc/source/filter/excel/excform.cxx @@ -1600,11 +1600,12 @@ void ExcelToSc::DoMulArgs( DefTokenId eId, sal_uInt8 nCnt ) // [Parameter{;Parameter}] if( nLast > nSkipEnd ) { + // nSkipEnd is either 0 or -1 => nLast >= 0 aPool << eParam[ nLast ]; for( nLauf = nLast - 1 ; nLauf > nSkipEnd ; nLauf-- ) { - if( nLauf != -1 ) // skip this parameter - aPool << ocSep << eParam[ nLauf ]; + // nLauf > nSkipEnd => nLauf >= 0 + aPool << ocSep << eParam[nLauf]; } } } |