diff options
| author | Lionel Elie Mamane <lionel@mamane.lu> | 2015-02-05 17:26:16 +0100 |
|---|---|---|
| committer | Michael Stahl <mstahl@redhat.com> | 2015-02-05 16:48:02 +0000 |
| commit | af9890c60f35c7b84df2543690b0b8c39a884bb6 (patch) | |
| tree | c993983fe76009009947532c4772b873682f863e /sc/source/filter/excel | |
| parent | e810928cea6535dd2fc187e18adea23e1a158e11 (diff) | |
Revert "ODF export: don't write invalid "group-name" attribute"
This reverts commit 2d4b87f0c1bfd97185a89c18d5b7680d11a958d6.
The reverted commit leads to the following regressions:
- Basic dialogs
(which were not targeted, but impacted, by the reverted commit)
with several RadioButtons sharing a group-name (as they will have a
tendency to do) cannot be loaded anymore, since the implementation
assumes (and checks) that names are unique.
- Even in forms, where a RadioButton had both a form:name and a
form:group-name attribute, the form:name attribute wins and thus
RadioButtons that has the same group-name but different form:name
(as they will tend to do) will not anymore be mutually exclusive,
which defeats their point.
Additionally, since it did not change the UI parts (property editor
window), the user was still presented with two different editable
properties "Name" and "Group Name", where "Group Name" was empty...
Change-Id: I1bff532a5a7336cf2eb0579bcd4e2d16be6480fe
Reviewed-on: https://gerrit.libreoffice.org/14338
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
Diffstat (limited to 'sc/source/filter/excel')
| -rw-r--r-- | sc/source/filter/excel/xiescher.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sc/source/filter/excel/xiescher.cxx b/sc/source/filter/excel/xiescher.cxx index bf5ca8ac0552..5e9fa522cf0e 100644 --- a/sc/source/filter/excel/xiescher.cxx +++ b/sc/source/filter/excel/xiescher.cxx @@ -2258,8 +2258,7 @@ void XclImpOptionButtonObj::DoProcessControl( ScfPropertySet& rPropSet ) const ScfPropertySet aProps( xCtrlModel ); OUString sGroupName = OUString::number( pLeader->GetDffShapeId() ); - // for radio buttons, "Name" is the group name - aProps.SetStringProperty( "Name", sGroupName ); + aProps.SetStringProperty( "GroupName", sGroupName ); aProps.SetStringProperty( "RefValue", OUString::number( nRefVal++ ) ); if ( pLeader->HasCellLink() && !pTbxObj->HasCellLink() ) { |