diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-21 19:13:06 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-23 08:16:18 +0200 |
| commit | d254f8a926d7d3ec4565d01f7a41ad3d9d7c9e87 (patch) | |
| tree | 6f33b99f7344c3861972760428fb974073130d8d /sc/source/filter/excel | |
| parent | 7c08c1af7116346f2dc0b669e231d82f4230a8c7 (diff) | |
loplugin:singlevalfields improve unaryoperator
when we see a unaryoperator, unless it's one of a small set, we can
know (mostly) that the field will not be written.
there is still a small risk of false+ with code taking references
via conditional expressions.
Change-Id: I96fa808067576a50e5eaf425338e225b4e0bdd4e
Reviewed-on: https://gerrit.libreoffice.org/53263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/source/filter/excel')
| -rw-r--r-- | sc/source/filter/excel/fontbuff.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sc/source/filter/excel/fontbuff.cxx b/sc/source/filter/excel/fontbuff.cxx index 52461ffde7f6..05416a6b8a3a 100644 --- a/sc/source/filter/excel/fontbuff.cxx +++ b/sc/source/filter/excel/fontbuff.cxx @@ -50,9 +50,6 @@ void LotusFontBuffer::Fill( const sal_uInt8 nIndex, SfxItemSet& rItemSet ) if( pCurrent->pHeight ) rItemSet.Put( *pCurrent->pHeight ); - if( pCurrent->pColor ) - rItemSet.Put( *pCurrent->pColor ); - if( nIndex & 0x08 ) { SvxWeightItem aWeightItem( WEIGHT_BOLD, ATTR_FONT_WEIGHT ); |