new loplugin:conststringfield

Look for const string fields which can be static, and
mostly convert them to OUStringLiteral

And add a getLength() method to OUStringLiteral to make
the transition easier.

Remove dead code in XclExpRoot::GenerateDefaultEncryptionData,
default password is never empty.

Change-Id: Iae75514d9dbb87289fd5b016222f640abe755091
Reviewed-on: https://gerrit.libreoffice.org/59204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 0 insertions, 11 deletions

diff --git a/sc/source/filter/xml/XMLStylesExportHelper.hxx b/sc/source/filter/xml/XMLStylesExportHelper.hxx
index 3fa54f49919e..3399174fb433 100644
--- a/sc/source/filter/xml/XMLStylesExportHelper.hxx
+++ b/sc/source/filter/xml/XMLStylesExportHelper.hxx
@@ -66,17 +66,6 @@ class ScMyValidationsContainer
 {
 private:
     ScMyValidationVec      aValidationVec;
-    const OUString         sERRALSTY;
-    const OUString         sIGNOREBL;
-    const OUString         sSHOWLIST;
-    const OUString         sTYPE;
-    const OUString         sSHOWINP;
-    const OUString         sSHOWERR;
-    const OUString         sINPTITLE;
-    const OUString         sINPMESS;
-    const OUString         sERRTITLE;
-    const OUString         sERRMESS;
-
 public:
                            ScMyValidationsContainer();
                            ~ScMyValidationsContainer();