perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related

There were over 150 places in *::Notify() functions that did some
dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the
base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast
operations come with quite some cost, so avoid if possible. Specifically
for ScFormulaCell::Notify() that created a bottleneck in scenarios where
cells were notified that already handled a previous notification. In
mass operations doing the dynamic_cast before it could be decided
whether having to act on it or not this made 2/3 of all time spent in
the Notify() call.

To get rid of that rename/move SfxSimpleHint to SfxHint and let classes
derive from SfxHint instead of SfxSimpleHint. This comes only with a
slight cost that an additional sal_uInt32 is transported in such hints,
initialized to 0, but this is neglectable compared to the huge gain.

For the rare cases where a Notify() actually expects both, an SfxHint
(formerly SfxSimpleHint) and a derived hint, this changed order of the
dynamic_cast involved so the simple SfxHint::GetId() is handled last.
Modules using such combinations can further optimize by treating the
simple SfxHint::GetId() first once verified that none of the other
derived hints use an ID not equal to zero respectively none of the ID
values the simple hint uses.

Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce
Reviewed-on: https://gerrit.libreoffice.org/29205
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

1 files changed, 35 insertions, 39 deletions

diff --git a/sc/source/ui/Accessibility/AccessiblePageHeader.cxx b/sc/source/ui/Accessibility/AccessiblePageHeader.cxx
index eda119923b45..956675a70fcb 100644
--- a/sc/source/ui/Accessibility/AccessiblePageHeader.cxx
+++ b/sc/source/ui/Accessibility/AccessiblePageHeader.cxx
@@ -35,7 +35,7 @@
 #include <com/sun/star/accessibility/AccessibleEventId.hpp>
 
 #include <vcl/window.hxx>
-#include <svl/smplhint.hxx>
+#include <svl/hint.hxx>
 #include <vcl/svapp.hxx>
 #include <unotools/accessiblestatesethelper.hxx>
 #include <svl/style.hxx>
@@ -122,51 +122,47 @@ void SAL_CALL ScAccessiblePageHeader::disposing()
 
 void ScAccessiblePageHeader::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
 {
-    const SfxSimpleHint* pSimpleHint = dynamic_cast<const SfxSimpleHint*>( &rHint );
-    if (pSimpleHint)
+    // only notify if child exist, otherwise it is not necessary
+    if (rHint.GetId() == SC_HINT_DATACHANGED)
     {
-        // only notify if child exist, otherwise it is not necessary
-        if (pSimpleHint->GetId() == SC_HINT_DATACHANGED)
+        ScHFAreas aOldAreas(maAreas);
+        std::for_each(aOldAreas.begin(), aOldAreas.end(), Acquire());
+        mnChildCount = -1;
+        getAccessibleChildCount();
+        for (sal_uInt8 i = 0; i < MAX_AREAS; ++i)
         {
-            ScHFAreas aOldAreas(maAreas);
-            std::for_each(aOldAreas.begin(), aOldAreas.end(), Acquire());
-            mnChildCount = -1;
-            getAccessibleChildCount();
-            for (sal_uInt8 i = 0; i < MAX_AREAS; ++i)
-            {
-                if ((aOldAreas[i] && maAreas[i] && !ScGlobal::EETextObjEqual(aOldAreas[i]->GetEditTextObject(), maAreas[i]->GetEditTextObject())) ||
+            if ((aOldAreas[i] && maAreas[i] && !ScGlobal::EETextObjEqual(aOldAreas[i]->GetEditTextObject(), maAreas[i]->GetEditTextObject())) ||
                     (aOldAreas[i] && !maAreas[i]) || (!aOldAreas[i] && maAreas[i]))
+            {
+                if (aOldAreas[i] && aOldAreas[i]->GetEditTextObject())
                 {
-                    if (aOldAreas[i] && aOldAreas[i]->GetEditTextObject())
-                    {
-                        AccessibleEventObject aEvent;
-                        aEvent.EventId = AccessibleEventId::CHILD;
-                        aEvent.Source = uno::Reference< XAccessibleContext >(this);
-                        aEvent.OldValue = uno::makeAny(uno::Reference<XAccessible>(aOldAreas[i]));
-
-                        CommitChange(aEvent); // child gone - event
-                        aOldAreas[i]->dispose();
-                    }
-                    if (maAreas[i] && maAreas[i]->GetEditTextObject())
-                    {
-                        AccessibleEventObject aEvent;
-                        aEvent.EventId = AccessibleEventId::CHILD;
-                        aEvent.Source = uno::Reference< XAccessibleContext >(this);
-                        aEvent.NewValue = uno::makeAny(uno::Reference<XAccessible>(maAreas[i]));
-
-                        CommitChange(aEvent); // new child - event
-                    }
+                    AccessibleEventObject aEvent;
+                    aEvent.EventId = AccessibleEventId::CHILD;
+                    aEvent.Source = uno::Reference< XAccessibleContext >(this);
+                    aEvent.OldValue = uno::makeAny(uno::Reference<XAccessible>(aOldAreas[i]));
+
+                    CommitChange(aEvent); // child gone - event
+                    aOldAreas[i]->dispose();
+                }
+                if (maAreas[i] && maAreas[i]->GetEditTextObject())
+                {
+                    AccessibleEventObject aEvent;
+                    aEvent.EventId = AccessibleEventId::CHILD;
+                    aEvent.Source = uno::Reference< XAccessibleContext >(this);
+                    aEvent.NewValue = uno::makeAny(uno::Reference<XAccessible>(maAreas[i]));
+
+                    CommitChange(aEvent); // new child - event
                 }
             }
-            std::for_each(aOldAreas.begin(), aOldAreas.end(), Release());
-        }
-        else if (pSimpleHint->GetId() == SC_HINT_ACC_VISAREACHANGED)
-        {
-            AccessibleEventObject aEvent;
-            aEvent.EventId = AccessibleEventId::VISIBLE_DATA_CHANGED;
-            aEvent.Source = uno::Reference< XAccessibleContext >(this);
-            CommitChange(aEvent);
         }
+        std::for_each(aOldAreas.begin(), aOldAreas.end(), Release());
+    }
+    else if (rHint.GetId() == SC_HINT_ACC_VISAREACHANGED)
+    {
+        AccessibleEventObject aEvent;
+        aEvent.EventId = AccessibleEventId::VISIBLE_DATA_CHANGED;
+        aEvent.Source = uno::Reference< XAccessibleContext >(this);
+        CommitChange(aEvent);
     }
 
     ScAccessibleContextBase::Notify(rBC, rHint);