diff options
author | Noel Grandin <noel@peralex.com> | 2014-06-18 12:14:29 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2014-06-24 11:34:21 +0200 |
commit | e2080e70fe8b085f18e868e46340454720fa94ca (patch) | |
tree | 4038d1d57b41b68a47d5ebbbe6ad390648ec6303 /sc/source/ui/Accessibility/AccessiblePreviewTable.cxx | |
parent | f910280b8704ed9c289150a4ca3c8d60e15d0d97 (diff) |
new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
Diffstat (limited to 'sc/source/ui/Accessibility/AccessiblePreviewTable.cxx')
-rw-r--r-- | sc/source/ui/Accessibility/AccessiblePreviewTable.cxx | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/sc/source/ui/Accessibility/AccessiblePreviewTable.cxx b/sc/source/ui/Accessibility/AccessiblePreviewTable.cxx index 1dd15c14f54c..78f1b3af1fca 100644 --- a/sc/source/ui/Accessibility/AccessiblePreviewTable.cxx +++ b/sc/source/ui/Accessibility/AccessiblePreviewTable.cxx @@ -204,8 +204,8 @@ sal_Int32 SAL_CALL ScAccessiblePreviewTable::getAccessibleRowExtentAt( sal_Int32 } else { - ScDocument* pDoc = mpViewShell->GetDocument(); - const ScMergeAttr* pItem = (const ScMergeAttr*)pDoc->GetAttr( + ScDocument& rDoc = mpViewShell->GetDocument(); + const ScMergeAttr* pItem = (const ScMergeAttr*)rDoc.GetAttr( static_cast<SCCOL>(rColInfo.nDocIndex), static_cast<SCROW>(rRowInfo.nDocIndex), mpTableInfo->GetTab(), ATTR_MERGE ); if ( pItem && pItem->GetRowMerge() > 0 ) nRows = pItem->GetRowMerge(); @@ -238,8 +238,8 @@ sal_Int32 SAL_CALL ScAccessiblePreviewTable::getAccessibleColumnExtentAt( sal_In } else { - ScDocument* pDoc = mpViewShell->GetDocument(); - const ScMergeAttr* pItem = (const ScMergeAttr*)pDoc->GetAttr( + ScDocument& rDoc = mpViewShell->GetDocument(); + const ScMergeAttr* pItem = (const ScMergeAttr*)rDoc.GetAttr( static_cast<SCCOL>(rColInfo.nDocIndex), static_cast<SCROW>(rRowInfo.nDocIndex), mpTableInfo->GetTab(), ATTR_MERGE ); if ( pItem && pItem->GetColMerge() > 0 ) nColumns = pItem->GetColMerge(); @@ -614,14 +614,14 @@ OUString SAL_CALL ScAccessiblePreviewTable::createAccessibleName() { OUString sName(SC_RESSTR(STR_ACC_TABLE_NAME)); - if (mpViewShell && mpViewShell->GetDocument()) + if (mpViewShell) { FillTableInfo(); if ( mpTableInfo ) { OUString sCoreName; - if (mpViewShell->GetDocument()->GetName( mpTableInfo->GetTab(), sCoreName )) + if (mpViewShell->GetDocument().GetName( mpTableInfo->GetTab(), sCoreName )) sName = sName.replaceFirst("%1", sCoreName); } } |