make Dialog destruction a little safer

rather keep the Impl object around for the lifetime of the Dialog
object.

where I saw a backtrace that looked like

vcl/source/window/dialog.cxx:1098: short Dialog::Execute(): Assertion
`mpDialogImpl' failed.
Dialog::Execute()
SalInstanceDialog::run()
ScSpellingEngine::ShowFinishDialog()
ScConversionEngineBase::FindNextConversionCell()
ScSpellingEngine::SpellNextDocument()
ScSpellDialogChildWindow::GetNextWrongSentence(bool)

Change-Id: I5858f3cd126185bc4f59932dfa53f6a6a3a66aa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180980
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins

0 files changed, 0 insertions, 0 deletions