diff options
author | Marco Cecchetti <marco.cecchetti@collabora.com> | 2017-09-30 17:51:26 +0200 |
---|---|---|
committer | Jan Holesovsky <kendy@collabora.com> | 2017-10-03 14:14:07 +0200 |
commit | c7d2de2905d53d12b186f577260fd95460f4eea5 (patch) | |
tree | 8d82f9bfa9742546668b0ce43dc611abd67becb0 /sc/source/ui/app/scmod.cxx | |
parent | b8ad0fc55baa69724e90dc3bb7d96fbd7149b163 (diff) |
lok: temporary workaround: disable formula mode for online
- Start empty spreadsheet, open it with two users (let's call them A &
B).
- Type "=" with user A.
- Start moving around to different cells with user B.
=> Cell name of user B's selected cell is entered in user A's formula.
This is due to the fact that ScModel::GetInputHandler() returns always
the input handler which is handling the edited formula and not the
input handler of the current view.
That really messes up collaborative editing, so better to disable it,
until we implement an alternative solution.
Change-Id: I6e779cba3f377d12b7a4a19a6ee53c924fc9ba20
Reviewed-on: https://gerrit.libreoffice.org/43036
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Diffstat (limited to 'sc/source/ui/app/scmod.cxx')
-rw-r--r-- | sc/source/ui/app/scmod.cxx | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx index bfbe59d72710..444fd7e1aa74 100644 --- a/sc/source/ui/app/scmod.cxx +++ b/sc/source/ui/app/scmod.cxx @@ -1670,6 +1670,12 @@ bool ScModule::IsFormulaMode() // Just keep function autopilot here for references to other documents bool bIsFormula = false; + // formula mode in online is not usable in collaborative mode, + // this is a workaround for disabling formula mode in online + // when there is more than a single view + if (comphelper::LibreOfficeKit::isActive() && SfxViewShell::GetActiveShells() > 1) + return false; + if ( nCurRefDlgId ) { SfxChildWindow* pChildWnd = lcl_GetChildWinFromAnyView( nCurRefDlgId ); |