clang-tidy modernize-pass-by-value in sc

Change-Id: Ia7ff651d1cbc119b36a9f8052594d03650988f59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137848
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 23 insertions, 17 deletions

diff --git a/sc/source/ui/dataprovider/csvdataprovider.cxx b/sc/source/ui/dataprovider/csvdataprovider.cxx
index 29391c378db9..b6ca0d023d97 100644
--- a/sc/source/ui/dataprovider/csvdataprovider.cxx
+++ b/sc/source/ui/dataprovider/csvdataprovider.cxx
@@ -13,6 +13,7 @@
 #include <stringutil.hxx>
 
 #include <tools/stream.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 #include <docsh.hxx>
 #include <orcus/csv_parser.hpp>
@@ -65,11 +66,11 @@ public:
 
 namespace sc {
 CSVFetchThread::CSVFetchThread(
-    ScDocument& rDoc, const OUString& mrURL, std::function<void()> aImportFinishedHdl,
+    ScDocument& rDoc, OUString aURL, std::function<void()> aImportFinishedHdl,
     std::vector<std::shared_ptr<sc::DataTransformation>>&& rDataTransformations)
     : Thread("CSV Fetch Thread")
     , mrDocument(rDoc)
-    , maURL(mrURL)
+    , maURL(std::move(aURL))
     , mbTerminate(false)
     , maDataTransformations(std::move(rDataTransformations))
     , maImportFinishedHdl(std::move(aImportFinishedHdl))
diff --git a/sc/source/ui/dataprovider/dataprovider.cxx b/sc/source/ui/dataprovider/dataprovider.cxx
index 72f674a7b99d..cc83294366cb 100644
--- a/sc/source/ui/dataprovider/dataprovider.cxx
+++ b/sc/source/ui/dataprovider/dataprovider.cxx
@@ -24,6 +24,7 @@
 #include <datamapper.hxx>
 #include <dbdata.hxx>
 #include <docsh.hxx>
+#include <utility>
 
 using namespace com::sun::star;
 
@@ -63,10 +64,10 @@ std::unique_ptr<SvStream> DataProvider::FetchStreamFromURL(const OUString& rURL,
     }
 }
 
-ExternalDataSource::ExternalDataSource(const OUString& rURL,
-        const OUString& rProvider, ScDocument* pDoc)
-    : maURL(rURL)
-    , maProvider(rProvider)
+ExternalDataSource::ExternalDataSource(OUString aURL,
+        OUString aProvider, ScDocument* pDoc)
+    : maURL(std::move(aURL))
+    , maProvider(std::move(aProvider))
     , mpDoc(pDoc)
 {
 }
@@ -246,8 +247,8 @@ void ScDBDataManager::WriteToDoc(ScDocument& rDoc)
         pDocShell->PostPaint(aDestRange, PaintPartFlags::All);
 }
 
-ScDBDataManager::ScDBDataManager(const OUString& rDBName, ScDocument* pDoc):
-    maDBName(rDBName),
+ScDBDataManager::ScDBDataManager(OUString aDBName, ScDocument* pDoc):
+    maDBName(std::move(aDBName)),
     mpDoc(pDoc)
 {
 }
diff --git a/sc/source/ui/dataprovider/datatransformation.cxx b/sc/source/ui/dataprovider/datatransformation.cxx
index 62c82adb93d4..b5ba65f5a5b8 100644
--- a/sc/source/ui/dataprovider/datatransformation.cxx
+++ b/sc/source/ui/dataprovider/datatransformation.cxx
@@ -15,6 +15,7 @@
 #include <svl/numformat.hxx>
 #include <svl/zforlist.hxx>
 #include <unotools/charclass.hxx>
+#include <utility>
 
 namespace {
 
@@ -112,9 +113,9 @@ sal_Unicode SplitColumnTransformation::getSeparator() const
     return mcSeparator;
 }
 
-MergeColumnTransformation::MergeColumnTransformation( std::set<SCCOL>&& rColumns, const OUString& rMergeString):
+MergeColumnTransformation::MergeColumnTransformation( std::set<SCCOL>&& rColumns, OUString aMergeString):
     maColumns(std::move(rColumns)),
-    maMergeString(rMergeString)
+    maMergeString(std::move(aMergeString))
 {
 }
 
@@ -650,9 +651,9 @@ const std::set<SCCOL>& NumberTransformation::getColumn() const
 }
 
 ReplaceNullTransformation::ReplaceNullTransformation(std::set<SCCOL>&& nCol,
-                                                     const OUString& sReplaceWith)
+                                                     OUString sReplaceWith)
     : mnCol(std::move(nCol))
-    , msReplaceWith(sReplaceWith)
+    , msReplaceWith(std::move(sReplaceWith))
 {
 }
 
@@ -1136,10 +1137,10 @@ const std::set<SCCOL>& DateTimeTransformation::getColumn() const
     return mnCol;
 }
 
-FindReplaceTransformation::FindReplaceTransformation(SCCOL nCol, const OUString& aFindString, const OUString& aReplaceString)
+FindReplaceTransformation::FindReplaceTransformation(SCCOL nCol, OUString aFindString, OUString aReplaceString)
     : mnCol(nCol)
-    , maFindString(aFindString)
-    , maReplaceString(aReplaceString)
+    , maFindString(std::move(aFindString))
+    , maReplaceString(std::move(aReplaceString))
 {
 }
 
@@ -1181,9 +1182,9 @@ const OUString& FindReplaceTransformation::getReplaceString() const
     return maReplaceString;
 }
 
-DeleteRowTransformation::DeleteRowTransformation(SCCOL nCol, const OUString& aFindString)
+DeleteRowTransformation::DeleteRowTransformation(SCCOL nCol, OUString aFindString)
     : mnCol(nCol)
-    , maFindString(aFindString)
+    , maFindString(std::move(aFindString))
 {
 }
 
diff --git a/sc/source/ui/dataprovider/htmldataprovider.cxx b/sc/source/ui/dataprovider/htmldataprovider.cxx
index 8b241ddfe049..b45fdaad568b 100644
--- a/sc/source/ui/dataprovider/htmldataprovider.cxx
+++ b/sc/source/ui/dataprovider/htmldataprovider.cxx
@@ -11,6 +11,7 @@
 #include <datamapper.hxx>
 #include <datatransformation.hxx>
 #include <salhelper/thread.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 #include <tools/stream.hxx>
 
diff --git a/sc/source/ui/dataprovider/sqldataprovider.cxx b/sc/source/ui/dataprovider/sqldataprovider.cxx
index a7d27dfa9426..a1907092afd7 100644
--- a/sc/source/ui/dataprovider/sqldataprovider.cxx
+++ b/sc/source/ui/dataprovider/sqldataprovider.cxx
@@ -18,6 +18,7 @@
 #include <com/sun/star/sdbc/XResultSetMetaData.hpp>
 #include <dbdocutl.hxx>
 #include <datamapper.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 #include <comphelper/processfactory.hxx>
 #include <tools/diagnose_ex.h>
diff --git a/sc/source/ui/dataprovider/xmldataprovider.cxx b/sc/source/ui/dataprovider/xmldataprovider.cxx
index 4ffa45bd16e7..d3f0735d69a2 100644
--- a/sc/source/ui/dataprovider/xmldataprovider.cxx
+++ b/sc/source/ui/dataprovider/xmldataprovider.cxx
@@ -13,6 +13,7 @@
 #include <filter.hxx>
 #include <document.hxx>
 #include <datamapper.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 #include <orcusfilters.hxx>
 #include <utility>