loplugin:stringadd convert chained append to +

which can use the more efficient *StringConcat

Also fix a crash in stringview plugin which
started happening while I working on this.

Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 6 insertions, 6 deletions

diff --git a/sc/source/ui/dbgui/asciiopt.cxx b/sc/source/ui/dbgui/asciiopt.cxx
index 5dcb1cbd251f..0d584b5291a6 100644
--- a/sc/source/ui/dbgui/asciiopt.cxx
+++ b/sc/source/ui/dbgui/asciiopt.cxx
@@ -228,17 +228,17 @@ OUString ScAsciiOptions::WriteToString() const
 
     aOutStr.append(",")
                //Token 5: Language
-               .append(static_cast<sal_Int32>(static_cast<sal_uInt16>(eLang))).append(",")
+               .append(static_cast<sal_Int32>(static_cast<sal_uInt16>(eLang))).append("," +
                //Token 6: Import quoted field as text.
-               .append(OUString::boolean( bQuotedFieldAsText )).append(",")
+               OUString::boolean( bQuotedFieldAsText ) + "," +
                //Token 7: Detect special numbers.
-               .append(OUString::boolean( bDetectSpecialNumber )).append(",")
+               OUString::boolean( bDetectSpecialNumber ) + "," +
                // Token 8: used for "Save as shown" in export options
-               .append(OUString::boolean( bSaveAsShown )).append(",")
+               OUString::boolean( bSaveAsShown ) +"," +
                // Token 9: used for "Save cell formulas" in export options
-               .append(OUString::boolean( bSaveFormulas )).append(",")
+               OUString::boolean( bSaveFormulas ) + "," +
                //Token 10: Trim Space
-               .append(OUString::boolean( bRemoveSpace ));
+               OUString::boolean( bRemoveSpace ));
     return aOutStr.makeStringAndClear();
 }