diff options
| author | Noel Grandin <noel@peralex.com> | 2015-10-27 15:12:58 +0200 |
|---|---|---|
| committer | Michael Stahl <mstahl@redhat.com> | 2015-10-27 15:35:36 +0000 |
| commit | 623f5b26ffd77041d0b06d7ce9c3b32d05625440 (patch) | |
| tree | ecd905d6657147b1c5a074b4d33f914f0039440c /sc/source/ui/docshell/documentlinkmgr.cxx | |
| parent | 446f17f6c1f98b17ceb6750f5dc67a27330d1351 (diff) | |
don't allocate rtl::Reference or SvRef on the heap
There is no point, since it's the size of a pointer anyway
Found by temporarily making their 'operator new' methods
deleted.
Change-Id: I265e40ce93ad4bad08b4f0bd49db08929e44b7d6
Reviewed-on: https://gerrit.libreoffice.org/19628
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Diffstat (limited to 'sc/source/ui/docshell/documentlinkmgr.cxx')
| -rw-r--r-- | sc/source/ui/docshell/documentlinkmgr.cxx | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/sc/source/ui/docshell/documentlinkmgr.cxx b/sc/source/ui/docshell/documentlinkmgr.cxx index 19a8f0953768..6a39a349ae92 100644 --- a/sc/source/ui/docshell/documentlinkmgr.cxx +++ b/sc/source/ui/docshell/documentlinkmgr.cxx @@ -100,7 +100,7 @@ bool DocumentLinkManager::idleCheckLinks() const sfx2::SvBaseLinks& rLinks = mpImpl->mpLinkManager->GetLinks(); for (size_t i = 0, n = rLinks.size(); i < n; ++i) { - sfx2::SvBaseLink* pBase = *rLinks[i]; + sfx2::SvBaseLink* pBase = rLinks[i].get(); ScDdeLink* pDdeLink = dynamic_cast<ScDdeLink*>(pBase); if (!pDdeLink || !pDdeLink->NeedsUpdate()) continue; @@ -121,7 +121,7 @@ bool DocumentLinkManager::hasDdeLinks() const const sfx2::SvBaseLinks& rLinks = mpImpl->mpLinkManager->GetLinks(); for (size_t i = 0, n = rLinks.size(); i < n; ++i) { - sfx2::SvBaseLink* pBase = *rLinks[i]; + sfx2::SvBaseLink* pBase = rLinks[i].get(); if (dynamic_cast<ScDdeLink*>(pBase)) return true; } @@ -142,7 +142,7 @@ bool DocumentLinkManager::updateDdeLinks( vcl::Window* pWin ) bool bAny = false; for (size_t i = 0, n = rLinks.size(); i < n; ++i) { - sfx2::SvBaseLink* pBase = *rLinks[i]; + sfx2::SvBaseLink* pBase = rLinks[i].get(); ScDdeLink* pDdeLink = dynamic_cast<ScDdeLink*>(pBase); if (!pDdeLink) continue; @@ -186,7 +186,7 @@ bool DocumentLinkManager::updateDdeLink( const OUString& rAppl, const OUString& bool bFound = false; for (size_t i = 0, n = rLinks.size(); i < n; ++i) { - ::sfx2::SvBaseLink* pBase = *rLinks[i]; + ::sfx2::SvBaseLink* pBase = rLinks[i].get(); ScDdeLink* pDdeLink = dynamic_cast<ScDdeLink*>(pBase); if (!pDdeLink) continue; @@ -212,7 +212,7 @@ size_t DocumentLinkManager::getDdeLinkCount() const const sfx2::SvBaseLinks& rLinks = mpImpl->mpLinkManager->GetLinks(); for (size_t i = 0, n = rLinks.size(); i < n; ++i) { - ::sfx2::SvBaseLink* pBase = *rLinks[i]; + ::sfx2::SvBaseLink* pBase = rLinks[i].get(); ScDdeLink* pDdeLink = dynamic_cast<ScDdeLink*>(pBase); if (!pDdeLink) continue; @@ -231,7 +231,7 @@ void DocumentLinkManager::disconnectDdeLinks() const sfx2::SvBaseLinks& rLinks = mpImpl->mpLinkManager->GetLinks(); for (size_t i = 0, n = rLinks.size(); i < n; ++i) { - ::sfx2::SvBaseLink* pBase = *rLinks[i]; + ::sfx2::SvBaseLink* pBase = rLinks[i].get(); ScDdeLink* pDdeLink = dynamic_cast<ScDdeLink*>(pBase); if (pDdeLink) pDdeLink->Disconnect(); |