make the Color constructors explicitly specify transparency

to reduce the churn, we leave the existing constructor in place,
and add a clang plugin to detect when the value passed to the
existing constructor may contain transparency/alpha data.

i.e. we leave expressions like Color(0xffffff) alone, but
warn about any non-constant expression, and any expression
like Color(0xff000000)

Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 1 insertions, 1 deletions

diff --git a/sc/source/ui/drawfunc/drawsh2.cxx b/sc/source/ui/drawfunc/drawsh2.cxx
index ca3713ef46f8..1b2ef3240c1e 100644
--- a/sc/source/ui/drawfunc/drawsh2.cxx
+++ b/sc/source/ui/drawfunc/drawsh2.cxx
@@ -333,7 +333,7 @@ static void setupFillColorForChart(SfxViewShell* pShell, SfxItemSet& rSet)
                                 sal_uInt32 nFillColor = 0;
                                 xPropSet->getPropertyValue("FillColor") >>= nFillColor;
 
-                                XFillColorItem aFillColorItem("", Color(nFillColor));
+                                XFillColorItem aFillColorItem("", Color(ColorTransparency, nFillColor));
                                 rSet.Put(aFillColorItem);
 
                                 if (comphelper::LibreOfficeKit::isActive())