diff options
| author | Katarina Behrens <Katarina.Behrens@cib.de> | 2015-08-24 13:00:08 +0200 |
|---|---|---|
| committer | Eike Rathke <erack@redhat.com> | 2015-08-24 13:05:29 +0000 |
| commit | e931b059571c9f0cad4cc5ec6bd75a3ab46fb0d1 (patch) | |
| tree | e321de7df74654571d97b15fcf528a742bd8df75 /sc/source/ui/formdlg | |
| parent | d2c09305084c218facdd282c3232a9929b81e342 (diff) | |
tdf#93437: release reference held by ScFormulaReferenceHelper
This does two things: reverts a revert of
087f7fe50b03307e2d9202365886e8c37bd7e6e3 -- turns out it was innocent.
Plus, it actually releases the reference that prevents destructor from
being called. It was actually ScFormulaDlg's own m_aHelper member variable
holding reference to 'this' (extra-wicked, through SetWindow(this)),
never releasing it.
Change-Id: I258a280e09674d1a2f1ddebea19ea1b42dcdc777
Reviewed-on: https://gerrit.libreoffice.org/17949
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Diffstat (limited to 'sc/source/ui/formdlg')
| -rw-r--r-- | sc/source/ui/formdlg/formula.cxx | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sc/source/ui/formdlg/formula.cxx b/sc/source/ui/formdlg/formula.cxx index d6c1b1734220..ba871d415bb3 100644 --- a/sc/source/ui/formdlg/formula.cxx +++ b/sc/source/ui/formdlg/formula.cxx @@ -248,6 +248,7 @@ void ScFormulaDlg::dispose() { ScModule* pScMod = SC_MOD(); ScFormEditData* pData = pScMod->GetFormEditData(); + m_aHelper.dispose(); if (pData) // close dosen't destroy; { |