diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:09:01 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:19:22 +0200 |
commit | 91dd2db17bd6cb9b357d1d69b187174e31eabef0 (patch) | |
tree | d634de3a1a6820904b5699c2136b79b1a5a807c7 /sc/source/ui/inc/undocell.hxx | |
parent | 6f8ea7e89ea190b9462c945d55a3ad8777b2f3ef (diff) |
loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
Diffstat (limited to 'sc/source/ui/inc/undocell.hxx')
-rw-r--r-- | sc/source/ui/inc/undocell.hxx | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/sc/source/ui/inc/undocell.hxx b/sc/source/ui/inc/undocell.hxx index 611fbc8ac20d..4c725dc242f7 100644 --- a/sc/source/ui/inc/undocell.hxx +++ b/sc/source/ui/inc/undocell.hxx @@ -49,7 +49,7 @@ public: SCCOL nNewCol, SCROW nNewRow, SCTAB nNewTab, const ScPatternAttr* pOldPat, const ScPatternAttr* pNewPat, const ScPatternAttr* pApplyPat ); - virtual ~ScUndoCursorAttr(); + virtual ~ScUndoCursorAttr() override; virtual void Undo() override; virtual void Redo() override; @@ -96,7 +96,7 @@ public: ScDocShell* pNewDocShell, const ScAddress& rPos, ValuesType& rOldValues, const OUString& rNewStr, EditTextObject* pObj = nullptr ); - virtual ~ScUndoEnterData(); + virtual ~ScUndoEnterData() override; virtual void Undo() override; virtual void Redo() override; @@ -124,7 +124,7 @@ public: ScDocShell* pNewDocShell, const ScAddress& rNewPos, const ScCellValue& rUndoCell, double nVal ); - virtual ~ScUndoEnterValue(); + virtual ~ScUndoEnterValue() override; virtual void Undo() override; virtual void Redo() override; @@ -147,7 +147,7 @@ class ScUndoSetCell : public ScSimpleUndo public: ScUndoSetCell( ScDocShell* pDocSh, const ScAddress& rPos, const ScCellValue& rOldVal, const ScCellValue& rNewVal ); - virtual ~ScUndoSetCell(); + virtual ~ScUndoSetCell() override; virtual void Undo() override; virtual void Redo() override; @@ -172,7 +172,7 @@ public: ScUndoPageBreak( ScDocShell* pNewDocShell, SCCOL nNewCol, SCROW nNewRow, SCTAB nNewTab, bool bNewColumn, bool bNewInsert ); - virtual ~ScUndoPageBreak(); + virtual ~ScUndoPageBreak() override; virtual void Undo() override; virtual void Redo() override; @@ -196,7 +196,7 @@ class ScUndoPrintZoom: public ScSimpleUndo public: ScUndoPrintZoom( ScDocShell* pNewDocShell, SCTAB nT, sal_uInt16 nOS, sal_uInt16 nOP, sal_uInt16 nNS, sal_uInt16 nNP ); - virtual ~ScUndoPrintZoom(); + virtual ~ScUndoPrintZoom() override; virtual void Undo() override; virtual void Redo() override; @@ -221,7 +221,7 @@ public: ScUndoThesaurus( ScDocShell* pNewDocShell, SCCOL nNewCol, SCROW nNewRow, SCTAB nNewTab, const ScCellValue& rOldText, const ScCellValue& rNewText ); - virtual ~ScUndoThesaurus(); + virtual ~ScUndoThesaurus() override; virtual void Undo() override; virtual void Redo() override; @@ -264,7 +264,7 @@ public: const ScNoteData& rNewData, SdrUndoAction* pDrawUndo ); - virtual ~ScUndoReplaceNote(); + virtual ~ScUndoReplaceNote() override; virtual void Undo() override; virtual void Redo() override; @@ -289,7 +289,7 @@ class ScUndoShowHideNote : public ScSimpleUndo { public: ScUndoShowHideNote( ScDocShell& rDocShell, const ScAddress& rPos, bool bShow ); - virtual ~ScUndoShowHideNote(); + virtual ~ScUndoShowHideNote() override; virtual void Undo() override; virtual void Redo() override; @@ -309,7 +309,7 @@ public: ScUndoDetective( ScDocShell* pNewDocShell, SdrUndoAction* pDraw, const ScDetOpData* pOperation, ScDetOpList* pUndoList = nullptr ); - virtual ~ScUndoDetective(); + virtual ~ScUndoDetective() override; virtual void Undo() override; virtual void Redo() override; @@ -332,7 +332,7 @@ public: //use nTab = -1 for global range names ScUndoRangeNames( ScDocShell* pNewDocShell, ScRangeName* pOld, ScRangeName* pNew , SCTAB nTab = -1); - virtual ~ScUndoRangeNames(); + virtual ~ScUndoRangeNames() override; virtual void Undo() override; virtual void Redo() override; @@ -361,7 +361,7 @@ class UndoSetCells : public ScSimpleUndo public: UndoSetCells( ScDocShell* pDocSh, const ScAddress& rTopPos ); - virtual ~UndoSetCells(); + virtual ~UndoSetCells() override; virtual void Undo() override; virtual void Redo() override; |