clang-tidy performance-unnecessary-value-param

Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 10 insertions, 10 deletions

diff --git a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx
index 0d8d066f94ff..b1d7a54d9a32 100644
--- a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx
+++ b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx
@@ -61,7 +61,7 @@ public:
     ScAddress mMinimumAddress;
     ScAddress mMaximumAddress;
 
-    AddressWalker(ScAddress aInitialAddress);
+    AddressWalker(const ScAddress& aInitialAddress);
 
     ScAddress current(SCCOL aRelativeCol = 0, SCROW aRelativeRow = 0, SCTAB aRelativeTab = 0);
 
@@ -81,7 +81,7 @@ public:
     ScDocument*                         mpDocument;
     formula::FormulaGrammar::Grammar    meGrammar;
 
-    AddressWalkerWriter(ScAddress aInitialAddress, ScDocShell* pDocShell, ScDocument* pDocument,
+    AddressWalkerWriter(const ScAddress& aInitialAddress, ScDocShell* pDocShell, ScDocument* pDocument,
             formula::FormulaGrammar::Grammar eGrammar );
 
     void writeFormula(const OUString& aFormula);
@@ -117,7 +117,7 @@ protected:
     sal_Int32 mIndex;
 
 public:
-    DataRangeIterator(ScRange aInputRange);
+    DataRangeIterator(const ScRange& aInputRange);
     virtual ~DataRangeIterator();
 
     virtual bool hasNext() = 0;
diff --git a/sc/source/ui/inc/cellsh.hxx b/sc/source/ui/inc/cellsh.hxx
index 5a3ee9ed6f37..50cd54eecccd 100644
--- a/sc/source/ui/inc/cellsh.hxx
+++ b/sc/source/ui/inc/cellsh.hxx
@@ -80,7 +80,7 @@ private:
     static void InitInterface_Impl();
 
 public:
-                ScCellShell( ScViewData* pData, VclPtr<vcl::Window> pFrameWin );
+                ScCellShell( ScViewData* pData, const VclPtr<vcl::Window>& pFrameWin );
     virtual     ~ScCellShell() override;
 
     void        Execute(SfxRequest &);
diff --git a/sc/source/ui/inc/notemark.hxx b/sc/source/ui/inc/notemark.hxx
index bf427a66de0e..f01cd52e603f 100644
--- a/sc/source/ui/inc/notemark.hxx
+++ b/sc/source/ui/inc/notemark.hxx
@@ -53,7 +53,7 @@ private:
 
 public:
                 ScNoteMarker( vcl::Window* pWin, vcl::Window* pRight, vcl::Window* pBottom, vcl::Window* pDiagonal,
-                                ScDocument* pD, ScAddress aPos, const OUString& rUser,
+                                ScDocument* pD, const ScAddress& aPos, const OUString& rUser,
                                 const MapMode& rMap, bool bLeftEdge, bool bForce, bool bKeyboard );
                 ~ScNoteMarker();
 
diff --git a/sc/source/ui/inc/optsolver.hxx b/sc/source/ui/inc/optsolver.hxx
index a46978b3c19e..1edbdecad7be 100644
--- a/sc/source/ui/inc/optsolver.hxx
+++ b/sc/source/ui/inc/optsolver.hxx
@@ -94,7 +94,7 @@ class ScOptSolverDlg : public ScAnyRefDlg
 {
 public:
                     ScOptSolverDlg( SfxBindings* pB, SfxChildWindow* pCW, vcl::Window* pParent,
-                                 ScDocShell* pDocSh, ScAddress aCursorPos );
+                                 ScDocShell* pDocSh, const ScAddress& aCursorPos );
                     virtual ~ScOptSolverDlg() override;
     virtual void    dispose() override;
 
diff --git a/sc/source/ui/inc/solvrdlg.hxx b/sc/source/ui/inc/solvrdlg.hxx
index 3879d66a813e..2739b24e0634 100644
--- a/sc/source/ui/inc/solvrdlg.hxx
+++ b/sc/source/ui/inc/solvrdlg.hxx
@@ -40,7 +40,7 @@ class ScSolverDlg : public ScAnyRefDlg
 public:
                     ScSolverDlg( SfxBindings* pB, SfxChildWindow* pCW, vcl::Window* pParent,
                                  ScDocument* pDocument,
-                                 ScAddress aCursorPos );
+                                 const ScAddress& aCursorPos );
                     virtual ~ScSolverDlg() override;
     virtual void    dispose() override;
 
diff --git a/sc/source/ui/inc/uiobject.hxx b/sc/source/ui/inc/uiobject.hxx
index a76e4b315977..b316aa58a13c 100644
--- a/sc/source/ui/inc/uiobject.hxx
+++ b/sc/source/ui/inc/uiobject.hxx
@@ -21,7 +21,7 @@ class ScGridWinUIObject : public WindowUIObject
 
 public:
 
-    ScGridWinUIObject(VclPtr<ScGridWindow> xGridWin);
+    ScGridWinUIObject(const VclPtr<ScGridWindow>& xGridWin);
 
     virtual StringMap get_state() override;
 
diff --git a/sc/source/ui/inc/undoblk.hxx b/sc/source/ui/inc/undoblk.hxx
index b5cc4ad789c1..1dd470ff264f 100644
--- a/sc/source/ui/inc/undoblk.hxx
+++ b/sc/source/ui/inc/undoblk.hxx
@@ -134,7 +134,7 @@ class ScUndoCut: public ScBlockUndo
 public:
                     ScUndoCut( ScDocShell* pNewDocShell,
                                ScRange aRange,              // adjusted for merged cells
-                               ScAddress aOldEnd,           // end position without adjustment
+                               const ScAddress& aOldEnd,           // end position without adjustment
                                const ScMarkData& rMark,     // selected sheets
                                ScDocument* pNewUndoDoc );
     virtual         ~ScUndoCut() override;
@@ -214,7 +214,7 @@ class ScUndoDragDrop: public ScMoveUndo
 {
 public:
                     ScUndoDragDrop( ScDocShell* pNewDocShell,
-                                    const ScRange& rRange, ScAddress aNewDestPos, bool bNewCut,
+                                    const ScRange& rRange, const ScAddress& aNewDestPos, bool bNewCut,
                                     ScDocument* pUndoDocument,
                                     bool bScenario );
     virtual         ~ScUndoDragDrop() override;