Apply new VclPtr clang plugin to catch potential problems.

Omit the plugin, and sw's FrameControlsManager for now.

Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f
Reviewed-on: https://gerrit.libreoffice.org/16117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

13 files changed, 21 insertions, 0 deletions

diff --git a/sc/source/ui/inc/scuitphfedit.hxx b/sc/source/ui/inc/scuitphfedit.hxx
index c22ec2510525..3fddc293ddad 100644
--- a/sc/source/ui/inc/scuitphfedit.hxx
+++ b/sc/source/ui/inc/scuitphfedit.hxx
@@ -104,6 +104,7 @@ private:
 
 class ScRightHeaderEditPage : public ScHFEditPage
 {
+    friend class VclPtr<ScRightHeaderEditPage>;
 public:
     static VclPtr<SfxTabPage>  Create( vcl::Window* pParent, const SfxItemSet* rCoreSet );
 
@@ -113,6 +114,7 @@ private:
 
 class ScLeftHeaderEditPage : public ScHFEditPage
 {
+    friend class VclPtr<ScLeftHeaderEditPage>;
 public:
     static VclPtr<SfxTabPage>  Create( vcl::Window* pParent, const SfxItemSet* rCoreSet );
 
@@ -122,6 +124,7 @@ private:
 
 class ScRightFooterEditPage : public ScHFEditPage
 {
+    friend class VclPtr<ScRightFooterEditPage>;
 public:
     static VclPtr<SfxTabPage>  Create( vcl::Window* pParent, const SfxItemSet* rCoreSet );
 
@@ -131,6 +134,7 @@ private:
 
 class ScLeftFooterEditPage : public ScHFEditPage
 {
+    friend class VclPtr<ScLeftFooterEditPage>;
 public:
     static VclPtr<SfxTabPage>  Create( vcl::Window* pParent, const SfxItemSet* rCoreSet );
 
diff --git a/sc/source/ui/inc/tabpages.hxx b/sc/source/ui/inc/tabpages.hxx
index c2f9c38d1e66..b2c20142ac37 100644
--- a/sc/source/ui/inc/tabpages.hxx
+++ b/sc/source/ui/inc/tabpages.hxx
@@ -26,6 +26,7 @@
 
 class ScTabPageProtection : public SfxTabPage
 {
+    friend class VclPtr<ScTabPageProtection>;
     static const sal_uInt16 pProtectionRanges[];
 public:
     static  VclPtr<SfxTabPage> Create          ( vcl::Window*               pParent,
diff --git a/sc/source/ui/inc/tpcalc.hxx b/sc/source/ui/inc/tpcalc.hxx
index 25bd390fed20..0b27e75b27b6 100644
--- a/sc/source/ui/inc/tpcalc.hxx
+++ b/sc/source/ui/inc/tpcalc.hxx
@@ -31,6 +31,7 @@ class ScDocOptions;
 
 class ScTpCalcOptions : public SfxTabPage
 {
+    friend class VclPtr<ScTpCalcOptions>;
 public:
     static  VclPtr<SfxTabPage> Create          ( vcl::Window*               pParent,
                                           const SfxItemSet*     rCoreSet );
diff --git a/sc/source/ui/inc/tpcompatibility.hxx b/sc/source/ui/inc/tpcompatibility.hxx
index 550bd9b0836c..322e50d003bb 100644
--- a/sc/source/ui/inc/tpcompatibility.hxx
+++ b/sc/source/ui/inc/tpcompatibility.hxx
@@ -16,6 +16,7 @@
 
 class ScTpCompatOptions : public SfxTabPage
 {
+    friend class VclPtr<ScTpCompatOptions>;
 public:
     using SfxTabPage::DeactivatePage;
 
diff --git a/sc/source/ui/inc/tpdefaults.hxx b/sc/source/ui/inc/tpdefaults.hxx
index 429cbabde87f..deb267368baa 100644
--- a/sc/source/ui/inc/tpdefaults.hxx
+++ b/sc/source/ui/inc/tpdefaults.hxx
@@ -16,6 +16,7 @@
 
 class ScTpDefaultsOptions : public SfxTabPage
 {
+    friend class VclPtr<ScTpDefaultsOptions>;
 public:
     using SfxTabPage::DeactivatePage;
 
diff --git a/sc/source/ui/inc/tpformula.hxx b/sc/source/ui/inc/tpformula.hxx
index 7397d062d31d..a3175b8ee1fd 100644
--- a/sc/source/ui/inc/tpformula.hxx
+++ b/sc/source/ui/inc/tpformula.hxx
@@ -30,6 +30,7 @@
 
 class ScTpFormulaOptions : public SfxTabPage
 {
+    friend class VclPtr<ScTpFormulaOptions>;
 public:
     using SfxTabPage::DeactivatePage;
 
diff --git a/sc/source/ui/inc/tphf.hxx b/sc/source/ui/inc/tphf.hxx
index da972cbd44a9..9f5c8a599a23 100644
--- a/sc/source/ui/inc/tphf.hxx
+++ b/sc/source/ui/inc/tphf.hxx
@@ -60,6 +60,7 @@ private:
 
 class ScHeaderPage : public ScHFPage
 {
+    friend class VclPtr<ScHeaderPage>;
 public:
     static VclPtr<SfxTabPage>  Create( vcl::Window* pParent, const SfxItemSet* rSet );
     static const sal_uInt16*      GetRanges();
@@ -70,6 +71,7 @@ private:
 
 class ScFooterPage : public ScHFPage
 {
+    friend class VclPtr<ScFooterPage>;
 public:
     static VclPtr<SfxTabPage>  Create( vcl::Window* pParent, const SfxItemSet* rSet );
     static const sal_uInt16*      GetRanges();
diff --git a/sc/source/ui/inc/tpprint.hxx b/sc/source/ui/inc/tpprint.hxx
index 5b8370f13267..bf38a927c3b6 100644
--- a/sc/source/ui/inc/tpprint.hxx
+++ b/sc/source/ui/inc/tpprint.hxx
@@ -25,6 +25,7 @@
 
 class ScTpPrintOptions : public SfxTabPage
 {
+    friend class VclPtr<ScTpPrintOptions>;
     VclPtr<CheckBox>       m_pSkipEmptyPagesCB;
     VclPtr<CheckBox>       m_pSelectedSheetsCB;
     VclPtr<CheckBox>       m_pForceBreaksCB;
diff --git a/sc/source/ui/inc/tpstat.hxx b/sc/source/ui/inc/tpstat.hxx
index d143610c37b9..14478dc7043e 100644
--- a/sc/source/ui/inc/tpstat.hxx
+++ b/sc/source/ui/inc/tpstat.hxx
@@ -26,6 +26,7 @@
 
 class ScDocStatPage: public SfxTabPage
 {
+    friend class VclPtr<ScDocStatPage>;
 public:
     static VclPtr<SfxTabPage> Create( vcl::Window* pParent, const SfxItemSet* rSet );
     virtual         ~ScDocStatPage();
diff --git a/sc/source/ui/inc/tpsubt.hxx b/sc/source/ui/inc/tpsubt.hxx
index a54536c11f79..3295262e33b2 100644
--- a/sc/source/ui/inc/tpsubt.hxx
+++ b/sc/source/ui/inc/tpsubt.hxx
@@ -76,6 +76,7 @@ private:
 
 class ScTpSubTotalGroup1 : public ScTpSubTotalGroup
 {
+    friend class VclPtr<ScTpSubTotalGroup1>;
 protected:
             ScTpSubTotalGroup1( vcl::Window*              pParent,
                                 const SfxItemSet&    rArgSet );
@@ -91,6 +92,7 @@ public:
 
 class ScTpSubTotalGroup2 : public ScTpSubTotalGroup
 {
+    friend class VclPtr<ScTpSubTotalGroup2>;
 protected:
             ScTpSubTotalGroup2( vcl::Window*              pParent,
                                 const SfxItemSet&    rArgSet );
@@ -106,6 +108,7 @@ public:
 
 class ScTpSubTotalGroup3 : public ScTpSubTotalGroup
 {
+    friend class VclPtr<ScTpSubTotalGroup3>;
 protected:
             ScTpSubTotalGroup3( vcl::Window*              pParent,
                                 const SfxItemSet&    rArgSet );
@@ -121,6 +124,7 @@ public:
 
 class ScTpSubTotalOptions : public SfxTabPage
 {
+    friend class VclPtr<ScTpSubTotalOptions>;
 protected:
             ScTpSubTotalOptions( vcl::Window*             pParent,
                                   const SfxItemSet&  rArgSet );
diff --git a/sc/source/ui/inc/tptable.hxx b/sc/source/ui/inc/tptable.hxx
index e135c91ea4ef..46042b854896 100644
--- a/sc/source/ui/inc/tptable.hxx
+++ b/sc/source/ui/inc/tptable.hxx
@@ -27,6 +27,7 @@
 
 class ScTablePage : public SfxTabPage
 {
+    friend class VclPtr<ScTablePage>;
     static const sal_uInt16 pPageTableRanges[];
 public:
     static  VclPtr<SfxTabPage> Create          ( vcl::Window*           pParent,
diff --git a/sc/source/ui/inc/tpusrlst.hxx b/sc/source/ui/inc/tpusrlst.hxx
index a0c8663df0d9..2a4c28ffc77f 100644
--- a/sc/source/ui/inc/tpusrlst.hxx
+++ b/sc/source/ui/inc/tpusrlst.hxx
@@ -32,6 +32,7 @@ class ScRangeUtil;
 
 class ScTpUserLists : public SfxTabPage
 {
+    friend class VclPtr<ScTpUserLists>;
 public:
     static  VclPtr<SfxTabPage> Create          ( vcl::Window*               pParent,
                                           const SfxItemSet*     rAttrSet );
diff --git a/sc/source/ui/inc/tpview.hxx b/sc/source/ui/inc/tpview.hxx
index f31c850a5eb7..baece6cffd4a 100644
--- a/sc/source/ui/inc/tpview.hxx
+++ b/sc/source/ui/inc/tpview.hxx
@@ -31,6 +31,7 @@ class ScViewOptions;
 
 class ScTpContentOptions : public SfxTabPage
 {
+    friend class VclPtr<ScTpContentOptions>;
     VclPtr<ListBox>         pGridLB;
     VclPtr<FixedText>       pColorFT;
     VclPtr<ColorListBox>    pColorLB;
@@ -84,6 +85,7 @@ public:
 class ScDocument;
 class ScTpLayoutOptions : public SfxTabPage
 {
+    friend class VclPtrInstance<ScTpLayoutOptions>;
     VclPtr<ListBox>        m_pUnitLB;
     VclPtr<MetricField>    m_pTabMF;