loplugin:constantparam in sc

Change-Id: I8608a6cb47972e9b838cc5ea431863348758ded0

4 files changed, 10 insertions, 26 deletions

diff --git a/sc/source/ui/inc/cbutton.hxx b/sc/source/ui/inc/cbutton.hxx
index 027dd786ee84..8cf9d7559725 100644
--- a/sc/source/ui/inc/cbutton.hxx
+++ b/sc/source/ui/inc/cbutton.hxx
@@ -48,8 +48,7 @@ public:
     Size    GetSizePixel() const                 { return aBtnSize; }
 
 private:
-    void    ImpDrawArrow( const Rectangle&  rRect,
-                          bool              bState );
+    void    ImpDrawArrow( const Rectangle&  rRect );
 
 protected:
     VclPtr<OutputDevice> pOut;
diff --git a/sc/source/ui/inc/csvgrid.hxx b/sc/source/ui/inc/csvgrid.hxx
index aa8a62ef869d..f6503fb70ec0 100644
--- a/sc/source/ui/inc/csvgrid.hxx
+++ b/sc/source/ui/inc/csvgrid.hxx
@@ -36,36 +36,21 @@ class ScEditEngineDefaulter;
 class ScAsciiOptions;
 class ScAccessibleCsvControl;
 
-const sal_uInt8 CSV_COLFLAG_NONE    = 0x00;         /// Nothing set.
-const sal_uInt8 CSV_COLFLAG_SELECT  = 0x01;         /// Column is selected.
-
 const sal_uInt32 CSV_COLUMN_INVALID = CSV_VEC_NOTFOUND;
 
 /** This struct contains the state of one table column. */
 struct ScCsvColState
 {
-    sal_Int32                   mnType;             /// Data type.
-    sal_uInt8                   mnFlags;            /// Flags (i.e. selection state).
+    sal_Int32            mnType;             /// Data type.
+    bool                 mbColumnSelected;
 
-    inline explicit             ScCsvColState(
-                                        sal_Int32 nType = CSV_TYPE_DEFAULT,
-                                        sal_uInt8 nFlags = CSV_COLFLAG_NONE ) :
-                                    mnType( nType ), mnFlags( nFlags ) {}
+    explicit             ScCsvColState( sal_Int32 nType = CSV_TYPE_DEFAULT ) :
+                                    mnType( nType ), mbColumnSelected( false ) {}
 
-    inline bool                 IsSelected() const;
-    inline void                 Select( bool bSel );
+    bool                 IsSelected() const { return mbColumnSelected; }
+    void                 Select( bool bSel ) { mbColumnSelected = bSel; }
 };
 
-inline bool ScCsvColState::IsSelected() const
-{
-    return (mnFlags & CSV_COLFLAG_SELECT) != 0;
-}
-
-inline void ScCsvColState::Select( bool bSel )
-{
-    if( bSel ) mnFlags |= CSV_COLFLAG_SELECT; else mnFlags &= ~CSV_COLFLAG_SELECT;
-}
-
 typedef ::std::vector< ScCsvColState > ScCsvColStateVec;
 
 /** A data grid control for the CSV import dialog. The design of this control
diff --git a/sc/source/ui/inc/pntlock.hxx b/sc/source/ui/inc/pntlock.hxx
index 6a514c7e1f03..1e1163afedc5 100644
--- a/sc/source/ui/inc/pntlock.hxx
+++ b/sc/source/ui/inc/pntlock.hxx
@@ -50,8 +50,8 @@ public:
     bool                    GetModified() const             { return bModified; }
 
     /** for recovery after reset */
-    void            SetLevel(sal_uInt16 nNew, bool bDoc)
-                        { if (bDoc) nDocLevel = nNew; else nLevel = nNew; }
+    void            SetDocLevel(sal_uInt16 nNew)
+                        { nDocLevel = nNew; }
 };
 
 #endif
diff --git a/sc/source/ui/inc/viewfunc.hxx b/sc/source/ui/inc/viewfunc.hxx
index 45ea187627b6..6ce056b9cfcc 100644
--- a/sc/source/ui/inc/viewfunc.hxx
+++ b/sc/source/ui/inc/viewfunc.hxx
@@ -214,7 +214,7 @@ public:
 
     void            RemoveManualBreaks();
 
-    void            SetPrintZoom(sal_uInt16 nScale, sal_uInt16 nPages);
+    void            SetPrintZoom(sal_uInt16 nScale);
     void            AdjustPrintZoom();
 
     bool            TestMergeCells();